Skip to content

fix: mark all keyFile and keyFilePath options deprecated#8617

Merged
bshaffer merged 3 commits intomainfrom
warn-veneer-keyfile
Sep 29, 2025
Merged

fix: mark all keyFile and keyFilePath options deprecated#8617
bshaffer merged 3 commits intomainfrom
warn-veneer-keyfile

Conversation

@bshaffer bshaffer requested review from a team September 22, 2025 21:22
@bshaffer bshaffer added the next release PRs to be included in the next release label Sep 22, 2025
@jeromegamez
Copy link
Copy Markdown
Contributor

jeromegamez commented Oct 12, 2025

I'm not sure, but is it possible that the @deprecated annotations for the config options break PHPStan?

Since upgrading to the latest version, PHPStan reports Call to deprecated method __construct() of class…, with or without using the deprecated options.

This is a PR in which I removed the keyFile option: https://github.com/kreait/firebase-php/pull/1026/files

jeromegamez added a commit to beste/firebase-php that referenced this pull request Nov 1, 2025
The deprecation error has been introduced with the changes in
googleapis/google-cloud-php#8617.

Until/Unless googleapis/google-cloud-php#8689 or
something similar is implemented, we need to ignore the error here.
jeromegamez added a commit to beste/firebase-php that referenced this pull request Nov 1, 2025
The deprecation error has been introduced with the changes in
googleapis/google-cloud-php#8617.

Until/Unless googleapis/google-cloud-php#8689 or
something similar is implemented, we need to ignore the error here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next release PRs to be included in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants