Conversation
|
Unbelievable 😅 Had I known... Third time's a charm! |
|
@jeromegamez I'm not so sure... I'm now thinking it may require we remove the original key from the commit, and that's why your last PR did't succeed. The error says "to push, remove secret from commit(s)" So I am now looking into other options |
Hectorhammett
left a comment
There was a problem hiding this comment.
This currently LGTM, but I find it funny how this is "circumvented" by just using an actual json instead of a file 🤔
I wonder if the check just reads "service account" on the file's name and freaks out. I can approve it if we agree that we are shipping it.
|
@Hectorhammett I think the issue actually that the service account file still appears in one of the commits, and so this PR would actually be ineffective. Converting this to draft and leaving it marked as |
|
I was able to mark this as an exception because it's for testing, let's hope that stays true for future releases! |
|
Two questions out of curiosity: Did you define this exception in the monorepo or in the core component subsplit? Do I remember correctly that the release job exited after failing to release the core component? If so, perhaps the workflow could be modified/spliz to at least deploy the rest of them, even when one fails? |
see #8657 and #8675
Removes the JSON file because it's still being flagged as credentials, which is breaking our release pipeline
@jeromegamez