chore(librarian): Only add header to files in .librarian/generator-input#14971
chore(librarian): Only add header to files in .librarian/generator-input#14971
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a bug introduced in a previous change that caused a specific 'DO NOT EDIT' header to be erroneously applied to all generated files. The fix refines the file processing workflow to ensure that this header is now correctly and exclusively added to files residing in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where a header was incorrectly added to all generated files. The proposed solution correctly isolates the intended files within a temporary directory, applies the header, and then moves them to the final destination. This approach is clean, effective, and resolves the issue described. The change is well-implemented and improves the generator's behavior.
This PR fixes a bug introduced in #14901 which adds the following text to all generated files. We only want this text added to
.librarian/generator-input