chore: librarian onboard pull request: 20260223T163038Z#15603
Closed
daniel-sanche wants to merge 1 commit intomainfrom
Closed
chore: librarian onboard pull request: 20260223T163038Z#15603daniel-sanche wants to merge 1 commit intomainfrom
daniel-sanche wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
Note: the dinal step of this PR failed: I created it manually, leaving out the piper id. If the piper id is required, we can delete this and try again |
Contributor
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the new Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request onboards the new google-cloud-workloadmanager client library. The changes consist mostly of boilerplate files generated for a new Python client. The code looks good overall. I've added a few minor suggestions to improve code style and maintainability by sorting __all__ definitions in a few __init__.py files.
Comment on lines
+164
to
+201
| __all__ = ( | ||
| "WorkloadManagerAsyncClient", | ||
| "AgentCommand", | ||
| "BigQueryDestination", | ||
| "Command", | ||
| "CreateEvaluationRequest", | ||
| "DeleteEvaluationRequest", | ||
| "DeleteExecutionRequest", | ||
| "Evaluation", | ||
| "Execution", | ||
| "ExecutionResult", | ||
| "GceInstanceFilter", | ||
| "GetEvaluationRequest", | ||
| "GetExecutionRequest", | ||
| "ListEvaluationsRequest", | ||
| "ListEvaluationsResponse", | ||
| "ListExecutionResultsRequest", | ||
| "ListExecutionResultsResponse", | ||
| "ListExecutionsRequest", | ||
| "ListExecutionsResponse", | ||
| "ListRulesRequest", | ||
| "ListRulesResponse", | ||
| "ListScannedResourcesRequest", | ||
| "ListScannedResourcesResponse", | ||
| "OperationMetadata", | ||
| "Resource", | ||
| "ResourceFilter", | ||
| "ResourceStatus", | ||
| "Rule", | ||
| "RuleExecutionResult", | ||
| "RuleOutput", | ||
| "RunEvaluationRequest", | ||
| "ScannedResource", | ||
| "ShellCommand", | ||
| "UpdateEvaluationRequest", | ||
| "ViolationDetails", | ||
| "WorkloadManagerClient", | ||
| ) |
Contributor
There was a problem hiding this comment.
For better maintainability and consistency, the __all__ list should be sorted alphabetically.
__all__ = (
"AgentCommand",
"BigQueryDestination",
"Command",
"CreateEvaluationRequest",
"DeleteEvaluationRequest",
"DeleteExecutionRequest",
"Evaluation",
"Execution",
"ExecutionResult",
"GceInstanceFilter",
"GetEvaluationRequest",
"GetExecutionRequest",
"ListEvaluationsRequest",
"ListEvaluationsResponse",
"ListExecutionResultsRequest",
"ListExecutionResultsResponse",
"ListExecutionsRequest",
"ListExecutionsResponse",
"ListRulesRequest",
"ListRulesResponse",
"ListScannedResourcesRequest",
"ListScannedResourcesResponse",
"OperationMetadata",
"Resource",
"ResourceFilter",
"ResourceStatus",
"Rule",
"RuleExecutionResult",
"RuleOutput",
"RunEvaluationRequest",
"ScannedResource",
"ShellCommand",
"UpdateEvaluationRequest",
"ViolationDetails",
"WorkloadManagerAsyncClient",
"WorkloadManagerClient",
)
Comment on lines
+19
to
+22
| __all__ = ( | ||
| "WorkloadManagerClient", | ||
| "WorkloadManagerAsyncClient", | ||
| ) |
Contributor
There was a problem hiding this comment.
For better maintainability and consistency, the __all__ list should be sorted alphabetically.
Suggested change
| __all__ = ( | |
| "WorkloadManagerClient", | |
| "WorkloadManagerAsyncClient", | |
| ) | |
| __all__ = ( | |
| "WorkloadManagerAsyncClient", | |
| "WorkloadManagerClient", | |
| ) |
Comment on lines
+30
to
+36
| __all__ = ( | ||
| "WorkloadManagerTransport", | ||
| "WorkloadManagerGrpcTransport", | ||
| "WorkloadManagerGrpcAsyncIOTransport", | ||
| "WorkloadManagerRestTransport", | ||
| "WorkloadManagerRestInterceptor", | ||
| ) |
Contributor
There was a problem hiding this comment.
For better maintainability and consistency, the __all__ list should be sorted alphabetically.
Suggested change
| __all__ = ( | |
| "WorkloadManagerTransport", | |
| "WorkloadManagerGrpcTransport", | |
| "WorkloadManagerGrpcAsyncIOTransport", | |
| "WorkloadManagerRestTransport", | |
| "WorkloadManagerRestInterceptor", | |
| ) | |
| __all__ = ( | |
| "WorkloadManagerGrpcAsyncIOTransport", | |
| "WorkloadManagerGrpcTransport", | |
| "WorkloadManagerRestInterceptor", | |
| "WorkloadManagerRestTransport", | |
| "WorkloadManagerTransport", | |
| ) |
Contributor
I wasn't able to re-create this issue. I created PR #15605 with the Here is the command I used |
parthea
requested changes
Feb 24, 2026
Contributor
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
Please could you run librarian again since there was an error getting the piper id?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR created by the Librarian CLI to onboard a new Cloud Client Library.
BEGIN_COMMIT
feat: onboard a new library
Library-IDs: google-cloud-workloadmanager
END_COMMIT
Librarian Version: v0.8.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c