chore(deps): update dependency requests to v2.33.0 [security] - autoclosed#16834
chore(deps): update dependency requests to v2.33.0 [security] - autoclosed#16834renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the version of the requests library in the sqlalchemy-spanner package. The reviewer pointed out that updating shared dependencies should be done consistently across the entire repository in a dedicated pull request to avoid version conflicts and maintain environment consistency.
| requests==2.33.0 \ | ||
| --hash=sha256:3324635456fa185245e24865e810cecec7b4caf933d7eb133dcde67d48cee69b \ | ||
| --hash=sha256:c7ebc5e8b0f21837386ad0e1c8fe8b829fa5f544d8df3b2253bff14ef29d7652 |
There was a problem hiding this comment.
Updating a common dependency like requests in a single package is a piecemeal change. According to the repository's general rules, changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal pull request rather than piecemeal. This ensures environment consistency and avoids version conflicts across the monorepo, especially for core dependencies like requests that are shared via google-api-core across multiple packages.
References
- Changes to shared configurations, like mypy flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
This PR contains the following updates:
==2.32.5→==2.33.0Requests has Insecure Temp File Reuse in its extract_zipped_paths() utility function
CVE-2026-25645 / GHSA-gc5v-m9x4-r6x2
More information
Details
Impact
The
requests.utils.extract_zipped_paths()utility function uses a predictable filename when extracting files from zip archives into the system temporary directory. If the target file already exists, it is reused without validation. A local attacker with write access to the temp directory could pre-create a malicious file that would be loaded in place of the legitimate one.Affected usages
Standard usage of the Requests library is not affected by this vulnerability. Only applications that call
extract_zipped_paths()directly are impacted.Remediation
Upgrade to at least Requests 2.33.0, where the library now extracts files to a non-deterministic location.
If developers are unable to upgrade, they can set
TMPDIRin their environment to a directory with restricted write access.Severity
CVSS:3.1/AV:L/AC:H/PR:L/UI:R/S:U/C:N/I:H/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
psf/requests (requests)
v2.33.0Compare Source
Announcements
uses Requests, please take a look at #7271. Give it a try, and report
any gaps or feedback you may have in the issue. 📣
Security
requests.utils.extract_zipped_pathsnow extractscontents to a non-deterministic location to prevent malicious file
replacement. This does not affect default usage of Requests, only
applications calling the utility function directly.
Improvements
Bugfixes
malformed authentication to be applied to Requests on
Python 3.11+. (#7205)
Deprecations
Documentation
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.