-
Notifications
You must be signed in to change notification settings - Fork 1.7k
for testing purposes #16836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for testing purposes #16836
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -598,11 +598,11 @@ def core_deps_from_source(session, protobuf_implementation): | |
| # Note: If a dependency is added to the `core_dependencies_from_source` list, | ||
| # the `prerel_deps` list in the `prerelease_deps` nox session should also be updated. | ||
| core_dependencies_from_source = [ | ||
| "googleapis-common-protos @ git+https://github.com/googleapis/google-cloud-python#egg=googleapis-common-protos&subdirectory=packages/googleapis-common-protos", | ||
| "google-api-core @ git+https://github.com/googleapis/google-cloud-python#egg=google-api-core&subdirectory=packages/google-api-core", | ||
| "google-auth @ git+https://github.com/googleapis/google-cloud-python#egg=google-auth&subdirectory=packages/google-auth", | ||
| "grpc-google-iam-v1 @ git+https://github.com/googleapis/google-cloud-python#egg=grpc-google-iam-v1&subdirectory=packages/grpc-google-iam-v1", | ||
| "proto-plus @ git+https://github.com/googleapis/google-cloud-python#egg=proto-plus&subdirectory=packages/proto-plus", | ||
| f"{CURRENT_DIRECTORY}/../googleapis-common-protos", | ||
| f"{CURRENT_DIRECTORY}/../google-api-core", | ||
| f"{CURRENT_DIRECTORY}/../google-auth", | ||
| f"{CURRENT_DIRECTORY}/../grpc-google-iam-v1", | ||
| f"{CURRENT_DIRECTORY}/../proto-plus", | ||
|
Comment on lines
+601
to
+605
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As noted in the template, using References
|
||
| ] | ||
|
|
||
| for dep in core_dependencies_from_source: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several concerns with switching to local relative paths in the template:
CURRENT_DIRECTORYis used in the f-strings but its definition is not visible in the diff. If it is not defined at the top level of the generatednoxfile.py, this will result in aNameErrorat runtime.../<package>) means the generatednoxfile.pywill only work if it remains within the specific directory structure of thegoogle-cloud-pythonmonorepo. This breaks portability for users who clone or use these packages standalone.google-auth: Thegoogle-authpackage resides in its own repository (googleapis/google-auth-python) and is not a sibling directory within thepackages/folder of this monorepo. Consequently,../google-authwill fail to resolve.Consider using a conditional approach that checks for the existence of local paths and falls back to git URLs if they are missing.
References