Skip to content

chore: remove description_override (batch 5 - to google-cloud-gke-multicloud)#16889

Merged
parthea merged 3 commits intogoogleapis:mainfrom
jskeet:description-batch-5
Apr 30, 2026
Merged

chore: remove description_override (batch 5 - to google-cloud-gke-multicloud)#16889
parthea merged 3 commits intogoogleapis:mainfrom
jskeet:description-batch-5

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 30, 2026

No description provided.

@jskeet jskeet requested a review from parthea April 30, 2026 07:50
@jskeet jskeet requested review from a team as code owners April 30, 2026 07:50
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes description_override fields from librarian.yaml for multiple Google Cloud libraries and synchronizes these changes by updating the corresponding package-level metadata and documentation. A review comment identifies that google-cloud-dns and google-cloud-geminidataanalytics are missing their package-level updates, which is inconsistent with the other changes in the PR and could lead to documentation regressions.

Comment thread librarian.yaml
default_version: v1
- name: google-cloud-dns
version: 0.36.1
description_override: provides methods that you can use to manage DNS for your applications.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description_override for google-cloud-dns is removed here, but there is no corresponding update to its package metadata in packages/google-cloud-dns/ within this pull request. Similarly, the override for google-cloud-geminidataanalytics at line 1284 is removed without a package-level update. Please ensure these packages are updated to maintain consistency with the other 18 libraries modified in this batch and to avoid potential regressions in documentation quality.

@parthea parthea merged commit fadfbc5 into googleapis:main Apr 30, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants