Skip to content

refactor(bigframes): Modularize compiler routing as proxy executor#16907

Draft
TrevorBergeron wants to merge 5 commits intomainfrom
tbegeron_proxy_exec
Draft

refactor(bigframes): Modularize compiler routing as proxy executor#16907
TrevorBergeron wants to merge 5 commits intomainfrom
tbegeron_proxy_exec

Conversation

@TrevorBergeron
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the DualCompilerProxyExecutor to manage the transition between ibis and sqlglot compilers, moving fallback logic out of BigQueryCachingExecutor. The BigQueryCachingExecutor is updated to support specific compiler selection and shared caching. Review feedback points out several critical issues in the new proxy executor, including the use of an undefined self._main attribute, missing imports for bigquery and CacheConfig, and type errors when passing labels to ExecutionSpec. Additionally, a bug was identified in bq_caching_executor.py where extra_labels were not correctly passed to the query execution method.

Comment thread packages/bigframes/bigframes/session/proxy_executor.py Outdated
Comment thread packages/bigframes/bigframes/session/bq_caching_executor.py Outdated
Comment thread packages/bigframes/bigframes/session/proxy_executor.py
Comment thread packages/bigframes/bigframes/session/proxy_executor.py Outdated
Comment thread packages/bigframes/bigframes/session/proxy_executor.py Outdated
Comment thread packages/bigframes/bigframes/session/proxy_executor.py Outdated
Comment thread packages/bigframes/bigframes/session/proxy_executor.py Outdated
Comment thread packages/bigframes/bigframes/session/proxy_executor.py
@TrevorBergeron TrevorBergeron changed the title refactor: Modularize compiler routing as proxy executor refactor(bigframes): Modularize compiler routing as proxy executor May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant