chore: enable generation for google-crc32c#16909
Merged
parthea merged 2 commits intogoogleapis:mainfrom May 1, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables code generation for the google-cloud-bigquery and google-crc32c libraries by removing the skip_generate flag in librarian.yaml. It also streamlines the .repo-metadata.json files for these packages by removing several metadata fields and updating the documentation link for google-crc32c. I have no feedback to provide.
Contributor
Author
|
Converting to draft as at least the BigQuery failure is still present. I'll wait until we see whether crc32c has been fixed before closing or amending the PR. |
jskeet
changed the title
jskeet
commented
May 1, 2026
| @@ -1,11 +1,9 @@ | |||
| { | |||
| "client_documentation": "https://github.com/googleapis/python-crc32c", | |||
| "client_documentation": "https://googleapis.dev/python/google-crc32c/latest", | |||
Contributor
Author
There was a problem hiding this comment.
Note that this doesn't exist, but won't be used anywhere anyway.
parthea
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't really generated, but this change will get
.repo-metadata.jsonup-to-date.The package previously had generation disabled due to test failures.