Skip to content

chore(proto-plus): update Python version and clean up enums.py #16912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chalmerlowe wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore(proto-plus): update Python version and clean up enums.py #16912

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a35f9d1
chore(proto-plus): track tech debt for _ignore_ in enums.py (Issue #1…
chalmerlowe May 1, 2026
60c9363
chore(proto-plus): update Python version requirement to 3.10
chalmerlowe May 1, 2026
60a0b03
chore(proto-plus): use walrus operator in repeated.py
chalmerlowe May 1, 2026
d971bcf
docs(proto-plus): update Python version in traceback example
chalmerlowe May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/proto-plus/proto/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ def __new__(mcls, name, bases, attrs):
opts = attrs.pop(pb_options, {})
# This is the only portable way to remove the _pb_options name
# from the enum attrs.
# In 3.7 onwards, we can define an _ignore_ attribute and do some
# mucking around with that.
# TODO: Use _ignore_ attribute to ignore _pb_options (Issue #16911)
if pb_options in attrs._member_names:
if isinstance(attrs._member_names, list):
idx = attrs._member_names.index(pb_options)
Expand Down
Loading