Skip to content

chore(django-google-spanner): update Python version to 3.10 #16914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chalmerlowe wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −3
Draft

chore(django-google-spanner): update Python version to 3.10 #16914

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd82d0d
chore(django-google-spanner): update Python version in setup.py to 3.10
chalmerlowe May 1, 2026
7ad363e
chore(django-google-spanner): update Python version in noxfile.py to …
chalmerlowe May 1, 2026
74fb288
Merge branch 'main' into chore/update-python-version-django-google-sp…
chalmerlowe May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/django-google-spanner/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
DEFAULT_PYTHON_VERSION = "3.14"

UNIT_TEST_PYTHON_VERSIONS = [
"3.9",
"3.10",
"3.11",
"3.12",
Expand Down Expand Up @@ -123,8 +122,7 @@ def default(session, django_version="5.2"):
@nox.session(python=ALL_PYTHON)
def unit(session):
"""Run the unit test suite."""
if session.python == "3.9":
session.skip("Python 3.9 is not supported for Django 5.2 tests")
Comment on lines -126 to -127
Copy link
Copy Markdown
Contributor

@parthea parthea May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should keep this until 3.9 is removed from gapic-generator and autogenerated packages which account for 90% of the packages in this repo.

Copy link
Copy Markdown
Contributor Author

@chalmerlowe chalmerlowe May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR and one's similar to it are blocked and are only presented for discussion.
Once the gapic-generator is updated fully to 3.10, these will be unblocked.

# TODO: Remove this check once support for Python 3.14 is added to Protobuf.
if session.python == "3.14":
session.skip("Protobuf upb implementation is not supported in Python 3.14 yet")
print("Unit tests with django 5.2")
Expand Down
Loading