Skip to content

tests: update googleapis sha in gapic-generator#16932

Draft
parthea wants to merge 1 commit intomainfrom
update-googleapis-sha-goldens
Draft

tests: update googleapis sha in gapic-generator#16932
parthea wants to merge 1 commit intomainfrom
update-googleapis-sha-goldens

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented May 4, 2026

Fixes #16931

@parthea parthea changed the title chore: update googleapis sha tests: update googleapis sha in gapic-generator May 4, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GAPIC generator's golden files for the Asset and Eventarc services, reflecting significant API additions. Key changes include the introduction of ResourceOwners, AssetEnrichment, and EffectiveTagDetails in the Asset service, along with enhanced search documentation for tags and security marks. The Eventarc service sees the addition of Enrollment, MessageBus, Pipeline, and GoogleApiSource resources, accompanied by their respective CRUD operations and generated code samples. Feedback was provided regarding a recurring typo in the anchor of a documentation URL for TagKey.namespacedName that appears in several files.

have a label ``env``.
- ``tagKeys:env`` to find Google Cloud resources that
have directly attached tags where the
```TagKey.namespacedName`` <https://cloud.google.com/resource-manager/reference/rest/v3/tagKeys#resource:-tagkey>`__
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL for TagKey.namespacedName contains a typo in the anchor. It should be tagKeys#resource:-tagkey_ instead of tagKeys#resource:-tagkey (the trailing underscore is missing in the source documentation).

have a label ``env``.
- ``tagKeys:env`` to find Google Cloud resources that
have directly attached tags where the
```TagKey.namespacedName`` <https://cloud.google.com/resource-manager/reference/rest/v3/tagKeys#resource:-tagkey>`__
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL for TagKey.namespacedName contains a typo in the anchor. It should be tagKeys#resource:-tagkey_ instead of tagKeys#resource:-tagkey (the trailing underscore is missing in the source documentation).

a label ``env``.
- ``tagKeys:env`` to find Google Cloud resources that have
directly attached tags where the
```TagKey.namespacedName`` <https://cloud.google.com/resource-manager/reference/rest/v3/tagKeys#resource:-tagkey>`__
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL for TagKey.namespacedName contains a typo in the anchor. It should be tagKeys#resource:-tagkey_ instead of tagKeys#resource:-tagkey (the trailing underscore is missing in the source documentation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update googleapis SHA used for golden files

1 participant