tests: update googleapis sha in gapic-generator#16932
Draft
Conversation
gapic-generator
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GAPIC generator's golden files for the Asset and Eventarc services, reflecting significant API additions. Key changes include the introduction of ResourceOwners, AssetEnrichment, and EffectiveTagDetails in the Asset service, along with enhanced search documentation for tags and security marks. The Eventarc service sees the addition of Enrollment, MessageBus, Pipeline, and GoogleApiSource resources, accompanied by their respective CRUD operations and generated code samples. Feedback was provided regarding a recurring typo in the anchor of a documentation URL for TagKey.namespacedName that appears in several files.
| have a label ``env``. | ||
| - ``tagKeys:env`` to find Google Cloud resources that | ||
| have directly attached tags where the | ||
| ```TagKey.namespacedName`` <https://cloud.google.com/resource-manager/reference/rest/v3/tagKeys#resource:-tagkey>`__ |
Contributor
| have a label ``env``. | ||
| - ``tagKeys:env`` to find Google Cloud resources that | ||
| have directly attached tags where the | ||
| ```TagKey.namespacedName`` <https://cloud.google.com/resource-manager/reference/rest/v3/tagKeys#resource:-tagkey>`__ |
Contributor
| a label ``env``. | ||
| - ``tagKeys:env`` to find Google Cloud resources that have | ||
| directly attached tags where the | ||
| ```TagKey.namespacedName`` <https://cloud.google.com/resource-manager/reference/rest/v3/tagKeys#resource:-tagkey>`__ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16931