Skip to content

chore(bigframes): fix ai multimodal tests#16935

Merged
sycai merged 6 commits intomainfrom
sycai_ai_test_fix
May 5, 2026
Merged

chore(bigframes): fix ai multimodal tests#16935
sycai merged 6 commits intomainfrom
sycai_ai_test_fix

Conversation

@sycai
Copy link
Copy Markdown
Contributor

@sycai sycai commented May 5, 2026

For ai.if, ai.score and ai.classify, it's not guaranteed that the result entries are not NULL.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the test_ai_if_multi_model and test_ai_classify_multi_model functions in test_ai.py by removing the bq_connection parameter and its usage within session.from_glob_path. I have no feedback to provide.

@sycai sycai requested review from TrevorBergeron and tswast May 5, 2026 04:27
@sycai sycai marked this pull request as ready for review May 5, 2026 15:53
@sycai sycai requested review from a team as code owners May 5, 2026 15:53
@sycai sycai changed the title fix(bigframes): fix ai multimodal tests chore(bigframes): fix ai multimodal tests May 5, 2026
@sycai sycai merged commit 5e8fb0d into main May 5, 2026
30 checks passed
@sycai sycai deleted the sycai_ai_test_fix branch May 5, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants