Skip to content

chore: remove references to Python 3.8 and 3.9#16940

Merged
parthea merged 4 commits intomainfrom
feat/drop-python-3.7-3.9-pandas-gbq
May 5, 2026
Merged

chore: remove references to Python 3.8 and 3.9#16940
parthea merged 4 commits intomainfrom
feat/drop-python-3.7-3.9-pandas-gbq

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe commented May 5, 2026

This PR updates pandas-gbq to establish Python 3.10 as the minimum supported version, dropping support for Python 3.9 and below.

Changes

  • Configuration: Updated noxfile.py to remove references to Python 3.9 and remove dead skip logic for 3.9.
  • Documentation: Updated CONTRIBUTING.rst to reflect the new supported Python versions and update Nox examples.
  • Runtime Check: Updated the runtime version check in pandas_gbq/__init__.py to warn for versions older than 3.10.

Fixes internal issue: http://b/482126936 🦕

@chalmerlowe chalmerlowe requested review from a team as code owners May 5, 2026 10:56
@chalmerlowe chalmerlowe requested review from shuoweil and removed request for a team May 5, 2026 10:56
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request drops support for Python 3.9 across the codebase, updating the contribution guidelines, CI configurations in noxfile.py, and runtime warning messages to reflect a new minimum requirement of Python 3.10. Feedback highlights that setup.py or pyproject.toml must be updated to reflect the new python_requires, and a minor version bump is required for this breaking change. Additionally, missing documentation link targets for Python 3.13 and 3.14 should be added to avoid broken references.

Comment thread packages/pandas-gbq/pandas_gbq/__init__.py Outdated
Comment on lines 230 to 232
.. _Python 3.10: https://docs.python.org/3.10/
.. _Python 3.11: https://docs.python.org/3.11/
.. _Python 3.12: https://docs.python.org/3.12/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The links for Python 3.13 and 3.14 are missing from the bottom of the file. Since these versions are listed as supported in the list above, their corresponding link targets should be added to avoid broken references in the documentation.

Suggested change
.. _Python 3.10: https://docs.python.org/3.10/
.. _Python 3.11: https://docs.python.org/3.11/
.. _Python 3.12: https://docs.python.org/3.12/
.. _Python 3.10: https://docs.python.org/3.10/
.. _Python 3.11: https://docs.python.org/3.11/
.. _Python 3.12: https://docs.python.org/3.12/
.. _Python 3.13: https://docs.python.org/3.13/
.. _Python 3.14: https://docs.python.org/3.14/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist:
Thanks for doing these checks!

In this case, please note: these links are not missing. They might be outside the diff's context window for the change OR something. But if you check, the lines you ask for are already there.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the confusion. You are correct; upon re-examining the file content, the link definitions for Python 3.13 and 3.14 are indeed present in the file. My previous comment was based on an incomplete view of the file context. Thank you for clarifying.

@parthea parthea changed the title feat(pandas-gbq): Drop support for Python 3.7, 3.8, and 3.9 chore: remove references to Python 3.8 and 3.9 May 5, 2026
@parthea parthea merged commit dea5a53 into main May 5, 2026
30 checks passed
@parthea parthea deleted the feat/drop-python-3.7-3.9-pandas-gbq branch May 5, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants