Skip to content

Feat/lab settings#7943

Open
mskorokhodov wants to merge 26 commits intomainfrom
feat/lab-settings
Open

Feat/lab settings#7943
mskorokhodov wants to merge 26 commits intomainfrom
feat/lab-settings

Conversation

@mskorokhodov
Copy link
Copy Markdown
Collaborator

@mskorokhodov mskorokhodov commented Apr 2, 2026 •
edited
Loading

Background

Description

Implemented fetch related settings in order to provide back compatibility configuration with old lab in gateway.

Screen.Recording.2026-04-15.at.11.48.57.mov

Checklist

  • Input validation
  • Output encoding
  • Authentication management
  • Session management
  • Access control
  • Cryptographic practices
  • Error handling and logging
  • Data protection
  • Communication security
  • System configuration
  • Database security
  • File management
  • Memory management
  • Testing

@mskorokhodov mskorokhodov marked this pull request as draft April 2, 2026 12:14
gemini-code-assist[bot]
gemini-code-assist bot reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Hive Router query plan rendering to the Hive Laboratory, featuring a new visual graph component and a text-based viewer. It also expands the laboratory's configuration options for fetch operations and subscription protocols. Feedback highlights the need to adhere to the repository's style guide by using fetchWithRetry for introspection, improving the retry logic to handle HTTP errors, securing unsafe JSON parsing in the UI, and optimizing performance in the graph rendering logic.

@mskorokhodov mskorokhodov requested review from ardatan and n1ru4l April 14, 2026 12:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/laboratory 0.1.4-alpha-20260415093228-17e1c35cf207aec6f6f51752b46a6c6b1efdac82 npm ↗︎ unpkg ↗︎
@graphql-hive/render-laboratory 0.1.4-alpha-20260415093228-17e1c35cf207aec6f6f51752b46a6c6b1efdac82 npm ↗︎ unpkg ↗︎
hive 11.0.3-alpha-20260415093228-17e1c35cf207aec6f6f51752b46a6c6b1efdac82 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 17e1c35cf207aec6f6f51752b46a6c6b1efdac82

ardatan
ardatan reviewed Apr 14, 2026
View reviewed changes
packages/libraries/laboratory/src/lib/request.ts Outdated
return signal;
}

export async function fetchWithRetry(
Copy link
Copy Markdown
Member

@ardatan ardatan Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this?

Copy link
Copy Markdown
Collaborator Author

@mskorokhodov mskorokhodov Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this we don't need, removed

ardatan
ardatan reviewed Apr 14, 2026
View reviewed changes
packages/libraries/laboratory/src/lib/request.ts Outdated
@@ -0,0 +1,30 @@
export function createRequestSignal(
Copy link
Copy Markdown
Member

@ardatan ardatan Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this too?

Copy link
Copy Markdown
Collaborator Author

@mskorokhodov mskorokhodov Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this we need for introspection query only

ardatan
ardatan reviewed Apr 14, 2026
View reviewed changes
@mskorokhodov mskorokhodov marked this pull request as ready for review April 14, 2026 13:27
@mskorokhodov mskorokhodov requested a review from ardatan April 14, 2026 16:47
ardatan
ardatan reviewed Apr 15, 2026
View reviewed changes
packages/libraries/laboratory/package.json Outdated
"eslint-plugin-react-refresh": "^0.4.26",
"globals": "^16.5.0",
"graphql": "^16.12.0",
"graphql-sse": "^2.5.3",
Copy link
Copy Markdown
Member

@ardatan ardatan Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need graphql-sse and graphql-ws dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardatan ardatan ardatan left review comments

@n1ru4l n1ru4l Awaiting requested review from n1ru4l

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mskorokhodov @ardatan @n1ru4l