Open
Conversation
…er-error # Conflicts: # test/common_test/sdk_builder_test.dart
# Conflicts: # lib/src/growth_book_sdk.dart
madhuchavva
requested changes
Jan 6, 2026
| typedef FeatureUsageCallbackWithUser = void Function(String, GBFeatureResult); | ||
|
|
||
| typedef FeatureRefreshCallback = void Function(bool); | ||
| typedef FeatureRefreshCallback = void Function(bool, GBError?); |
Contributor
There was a problem hiding this comment.
This is a breaking change. Let us do it with backwards compatibility
Collaborator
Author
There was a problem hiding this comment.
We have created V2 handlers (CacheRefreshHandlerV2, setRefreshHandlerV2) with GBError? support, while keeping original handlers as @Deprecated but fully functional. Old handlers are internally wrapped to work with the V2 implementation.
Note: FeatureRefreshCallback is not exposed to users in GBSDKBuilderApp - it's only stored internally in the Options class, so the deprecation there doesn't affect the public API surface.
Existing code works unchanged with deprecation warnings guiding migration.
…r as deprecated to follow backwards compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds GbError support to the RefreshHandler, allowing refresh issues to be tracked and reported through analytics.