Skip to content

Fix getting version string for release builds#192

Merged
bitmold merged 2 commits intoguardianproject:masterfrom
syphyr:fix_build
Apr 16, 2026
Merged

Fix getting version string for release builds#192
bitmold merged 2 commits intoguardianproject:masterfrom
syphyr:fix_build

Conversation

@syphyr
Copy link
Copy Markdown
Contributor

@syphyr syphyr commented Apr 4, 2026

Fix getting the version strings to create release builds.
Fix an echo statement from being shown twice.

@syphyr syphyr changed the title Fix getting version string and compiling resources Fix getting version string for release builds Apr 10, 2026
@syphyr
Copy link
Copy Markdown
Contributor Author

syphyr commented Apr 10, 2026

I removed trying to fix the resource files from this PR.

@syphyr
Copy link
Copy Markdown
Contributor Author

syphyr commented Apr 11, 2026

Orbot uses getVersionName() the same exact way as tor-android now with recent changes, which is why getVersionName().get() is now the proper way of calling the function to get the version string.

@bitmold bitmold merged commit 67e66e2 into guardianproject:master Apr 16, 2026
@bitmold
Copy link
Copy Markdown
Contributor

bitmold commented Apr 16, 2026

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants