Skip to content

command/meta: Fix PSS migration during provider upgrade#38244

Open
radeksimko wants to merge 3 commits intomainfrom
radek/b-fix-pss-provider-upgrade
Open

command/meta: Fix PSS migration during provider upgrade#38244
radeksimko wants to merge 3 commits intomainfrom
radek/b-fix-pss-provider-upgrade

Conversation

@radeksimko
Copy link
Copy Markdown
Member

@radeksimko radeksimko commented Mar 6, 2026

This ensures that the correct (old) provider is used to read the old state(s).

As discussed internally we'll need to still address the end-user migration paths to avoid relying on the backend state file always being there.

IMHO some of the codepaths will likely look the same as I'd expect us to want to avoid allowing multiple versions of the same provider in the lockfile.

I assume there will still be the concept of PreviousLocks being passed around - perhaps we'd make the names migration-specific but I'm not sure. The problem of schema caching is still relevant too.

Target Release

1.16.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@radeksimko radeksimko added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Mar 6, 2026
@radeksimko radeksimko force-pushed the radek/b-fix-pss-provider-upgrade branch from dcecb82 to 447450d Compare March 6, 2026 14:59
Copy link
Copy Markdown
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a look and left some comments. I'm going to ask internally for advice about how to handle the provider cache issue.

Also, while debugging I found some fixes needed for diagnostics: #38275 . It could be worth cherry-picking the change into your branch or rebasing once it's merged.

Comment thread internal/command/meta_backend.go Outdated
Comment thread internal/command/meta_backend.go
@radeksimko radeksimko force-pushed the radek/b-fix-pss-provider-upgrade branch 4 times, most recently from 16057f0 to 6e4e2a6 Compare March 23, 2026 16:27
@radeksimko radeksimko force-pushed the radek/b-fix-pss-provider-upgrade branch from 6e4e2a6 to c4f90b0 Compare March 23, 2026 16:34
@radeksimko radeksimko marked this pull request as ready for review March 23, 2026 16:46
@radeksimko radeksimko requested a review from a team as a code owner March 23, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants