command/meta: Fix PSS migration during provider upgrade#38244
Open
radeksimko wants to merge 3 commits intomainfrom
Open
command/meta: Fix PSS migration during provider upgrade#38244radeksimko wants to merge 3 commits intomainfrom
radeksimko wants to merge 3 commits intomainfrom
Conversation
dcecb82 to
447450d
Compare
SarahFrench
reviewed
Mar 13, 2026
Member
SarahFrench
left a comment
There was a problem hiding this comment.
I've taken a look and left some comments. I'm going to ask internally for advice about how to handle the provider cache issue.
Also, while debugging I found some fixes needed for diagnostics: #38275 . It could be worth cherry-picking the change into your branch or rebasing once it's merged.
16057f0 to
6e4e2a6
Compare
6e4e2a6 to
c4f90b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the correct (old) provider is used to read the old state(s).
As discussed internally we'll need to still address the end-user migration paths to avoid relying on the backend state file always being there.
IMHO some of the codepaths will likely look the same as I'd expect us to want to avoid allowing multiple versions of the same provider in the lockfile.
I assume there will still be the concept of
PreviousLocksbeing passed around - perhaps we'd make the names migration-specific but I'm not sure. The problem of schema caching is still relevant too.Target Release
1.16.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry