Bump flat-cache to ^6.x (fix inflight vulnerability)#98
Open
zalesky wants to merge 1 commit intohipstersmoothie:masterfrom
Open
Bump flat-cache to ^6.x (fix inflight vulnerability)#98zalesky wants to merge 1 commit intohipstersmoothie:masterfrom
zalesky wants to merge 1 commit intohipstersmoothie:masterfrom
Conversation
Author
|
@hipstersmoothie @Cloud2Software Please review and merge this PR. |
|
How does this compare to #97 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on node v22.16.0 (npm v10.9.2)
Closes #93
This PR updates the affected package to address a known security vulnerability, ensuring it is safe to use within the project.
⸻
🔒 Security Information
• Vulnerability type: Missing Release of Resource after Effective Lifetime
• Severity:
• Snyk CVSS v3.1: 6.2 (Medium)
• NVD: No CVE assigned yet
• Source: Snyk
⸻
🧠 Details
The vulnerability is caused by the makeres function failing to properly delete keys from the reqs object after callbacks are executed. This leads to a memory leak which can cause resource exhaustion, resulting in a Node.js process crash.
• The issue exists in a non-maintained library
• There is no official fix
• Several dependent packages have resolved the issue by removing the dependency
⸻
✅ Resolution
This PR updates the dependency to a safe or patched version (or eliminates the vulnerable package if that’s the case), which resolves the issue and allows continued use without exposure to the vulnerability.
⸻
🛡️ Impact
• Fixes memory leak vulnerability
• Reduces risk of application crash due to resource exhaustion
• Required for safe package usage in production