Updated object store with Filtering and Pagination#287
Updated object store with Filtering and Pagination#287pavan-traceable merged 15 commits intomainfrom
Conversation
…race/config-service into filtering-pagination-support-objectstore
…ering-pagination-support-objectstore
| configChangeEventGenerator, | ||
| clientConfig); | ||
| this.configServiceBlockingStub = configServiceBlockingStub; | ||
| this.resourceName = resourceName; |
There was a problem hiding this comment.
So this is why you initially had that method it in the IdentifiedObjectStore I'm guessing. Rather than shadowing these variables in the subclass, could we just set them to package private in IdentifiedObjectStore?
There was a problem hiding this comment.
yes, may be i should have explained to you then itself.
There was a problem hiding this comment.
Sorry I should be clearer with my comments - by setting "them" package private I meant the declarations of the variables from IdentifiedObjectStore that you were shadowing in this subclass.
I would still keep the filter impl in this subclass because that's actually the method doing what this class is built/named for - pushing down the filter.
There was a problem hiding this comment.
I have kept methods here and added variables also here. Make variables package private in IdentifiedObjectStore leading to errors in ContextuallyIdentifiedObjectStore.
Cannot reference 'IdentifiedObjectStore.configServiceBlockingStub' before superclass constructor is called
There was a problem hiding this comment.
That's just a name clash since that inner class is referencing unrelated parent class variables
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
============================================
- Coverage 79.93% 75.73% -4.21%
- Complexity 496 556 +60
============================================
Files 55 63 +8
Lines 2432 2839 +407
Branches 108 134 +26
============================================
+ Hits 1944 2150 +206
- Misses 427 607 +180
- Partials 61 82 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Description
Updaed IdentifiedObjectStore With Filtering and Pagination.