Skip to content

ENGTAI-63112: Added Http Event Collector Channel config Protos #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kunal-8789 merged 1 commit into from
Jun 4, 2025
Merged

ENGTAI-63112: Added Http Event Collector Channel config Protos #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...i/src/main/proto/org/hypertrace/notification/config/service/v1/notification_channel.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@ message NotificationChannelMutableData {
repeated AwsS3BucketChannelConfig s3_bucket_channel_config = 4;
repeated SplunkIntegrationChannelConfig splunk_integration_channel_config = 5;
repeated SyslogIntegrationChannelConfig syslog_integration_channel_config = 6;
repeated HttpEventCollectorChannelConfig http_event_collector_channel_config = 7;
}

message HttpEventCollectorChannelConfig {
Copy link
Copy Markdown
Contributor

@kotharironak kotharironak Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still coming from hypertrace side? Can you confirm?

Copy link
Copy Markdown
Contributor Author

@Kunal-8789 Kunal-8789 Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Ronak, notification channels and rules are still driven by hypertrace config.

oneof channel_type {
SplunkIntegrationChannelConfig splunk_integration_channel_config = 1;
CrowdStrikeIntegrationChannelConfig crowd_strike_integration_channel_config = 2;
}
}

message AwsS3BucketChannelConfig {
Expand Down Expand Up @@ -60,3 +68,7 @@ message SplunkIntegrationChannelConfig {
message SyslogIntegrationChannelConfig {
string syslog_server_integration_id = 1;
}

message CrowdStrikeIntegrationChannelConfig {
string crowd_strike_integration_id = 1;
}