Claude/fix issue 1244 no blocks in switch cases#1248
Open
GrahamTheCoder wants to merge 5 commits intoicsharpcode:masterfrom
Open
Claude/fix issue 1244 no blocks in switch cases#1248GrahamTheCoder wants to merge 5 commits intoicsharpcode:masterfrom
GrahamTheCoder wants to merge 5 commits intoicsharpcode:masterfrom
Conversation
GrahamTheCoder
force-pushed
the
claude/fix-issue-1244-no-blocks-in-switch-cases
branch
from
9ef905c to
2fa30bf
Compare
…ctions Only wrap switch case statements in a Block when a local variable declaration is present. Otherwise emit statements directly, eliminating the extra level of braces and indentation. https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
…y braces in switch cases Update all existing Select Case tests to reflect the new output format (no block braces when no local variable is declared). Add two new tests: one verifying no blocks are emitted for cases without local declarations, and one verifying blocks are still emitted when local variables are present. https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
…urn null, not return default String is a reference type so Nothing converts to null (not default). Confirmed by ParameterTests.cs:35 which has the same pattern. https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
GrahamTheCoder
force-pushed
the
claude/fix-issue-1244-no-blocks-in-switch-cases
branch
from
b8c8164 to
a39c7ae
Compare
…n Vsix not built The Vsix project uses UseWPF=true with net472, which fails SDK validation when MSBuild tries to build it as a dependency of Tests.csproj on newer .NET SDK versions. Setting Build="false" prevents this. Also makes the VsixDoesNotReferenceNewerBclPolyfillsThanOldestSupportedVs test skip gracefully when the Vsix output directory is absent (matching the second test). https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
…indows The net472+UseWPF Vsix project cannot be evaluated by the .NET 10 SDK without triggering 'target platform must be set to Windows'. Referencing it from Tests.csproj (even with Build=false) causes dotnet build to fail. Remove the reference - the Vsix tests already skip gracefully when the output directory is absent (VsixDoesNotReferenceNewerBclPolyfillsThanOldestSupportedVs now returns early like the second test). Build Vsix separately with msbuild. https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1244