Fix #803: Use C# 9 relational patterns for VB Case Is <op> constant#1251
Merged
GrahamTheCoder merged 5 commits intoicsharpcode:masterfrom Apr 18, 2026
Conversation
GrahamTheCoder
force-pushed
the
claude/fix-issue-803-relational-switch-pattern
branch
from
9319003 to
dc08ad9
Compare
GrahamTheCoder
commented
Apr 14, 2026
| CS.SyntaxKind.GreaterThanEqualsToken => (SyntaxKind.CaseGreaterThanOrEqualClause, SyntaxKind.GreaterThanEqualsToken), | ||
| _ => throw new NotSupportedException($"Relational operator token {csTokenKind} not supported in VB case clause") | ||
| }; | ||
|
|
Member
Author
There was a problem hiding this comment.
Implementation in C# -> VB direction with no test
…> constant` When converting VB `Select Case` with `Case Is < value`, `Case Is > value`, etc. (RelationalCaseClauseSyntax), emit clean C# 9 relational patterns (`case < 1000:`) instead of the verbose `case var @case when @case < 1000:` pattern, for non-object, non-string comparisons where the case value is a constant expression. Also handle RelationalPatternSyntax in the C#→VB converter so that C# 9 relational patterns round-trip correctly back to VB `Case Is <op> value`. https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
…avoid VB extension method resolution https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
Tests that C# 9 switch statement relational patterns (case < 0:) convert correctly to VB Case Is < 0 clauses, addressing the missing test noted in code review. https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX
…match actual converter output
GrahamTheCoder
force-pushed
the
claude/fix-issue-803-relational-switch-pattern
branch
from
3c098b1 to
bccf8e0
Compare
GrahamTheCoder
deleted the
claude/fix-issue-803-relational-switch-pattern
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #803
When converting VB
Select CasewithCase Is < value,Case Is > value, etc. (RelationalCaseClauseSyntax), emit clean C# 9 relational patterns (case < 1000:) instead of the verbosecase var @case when @case < 1000:pattern, for non-object, non-string comparisons where the case value is a constant expression.Also handle RelationalPatternSyntax in the C#→VB converter so that C# 9 relational patterns round-trip correctly back to VB
Case Is <op> value.https://claude.ai/code/session_01AkwUvu3XuCdj3D4axoX4UX