Open
Conversation
…workflow
- Add /health liveness probe (JSON, no auth, no DB) in core/views/common.py
- Wire /health route in core/urls.py
- Register Fly HTTP health check in fly.toml
- Add 31-test smoke suite (tests/test_smoke.py) covering:
- P0: liveness (/health, homepage, login page)
- P1: API docs (swagger-ui, redoc), version verification
- P2: auth enforcement (12 endpoints), admin site, static files,
HTTPS enforcement, security headers, 404 handling
- Add --smoke-url opt-in CLI option and @pytest.mark.smoke marker
- Add post-deploy smoke-test CI job in fly_dev.yml (targets jhe.fly.dev)
- Add on-demand smoke_test.yml workflow (workflow_dispatch for any URL)
- Add comprehensive doc/TESTING.md for new contributors
- Link testing docs from README.md
travis-sauer-oltech
force-pushed
the
feat/smoke-tests
branch
from
a6ce176 to
696bce4
Compare
for more information, see https://pre-commit.ci
minrk
reviewed
Feb 23, 2026
Member
minrk
left a comment
minrk
left a comment
There was a problem hiding this comment.
I think in principle these make sense.
I think most of these tests should be run in the regular test suite, too, is it possible to configure the tests to run against a localhost URL when smoke-url is not specified, and also run against a live instance when specified?
That seems okay as a later improvement, too.
| ("/api/v1/data_sources", "Data sources list"), | ||
| ("/api/v1/jhe_settings", "JHE settings list"), | ||
| ], | ||
| ids=lambda v: v if isinstance(v, str) and v.startswith("/") else "", |
Member
There was a problem hiding this comment.
I don't think this ids does anything, what's the goal here?
Co-authored-by: Min RK <benjaminrk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.