fix: resolve all high-severity issues from scan report#443
Merged
Conversation
color.py / scanner.py — replace deprecated os.popen('stty size') with
shutil.get_terminal_size(fallback=...) which is safe in non-TTY contexts
(piped/redirected output) and does not raise ValueError on empty output.
scanner.py — replace os.system() with subprocess.run([cmd]) for the
clear-screen call, eliminating the shell spawn and making the intent
explicit.
dependency.py — replace shell=True subprocess.run() with shell=False
plus shlex.split() on the install command string, removing the shell
injection vector in the package installer.
logger.py — extend _sanitize_message() to mask WPA/WEP credentials
that may appear in logged output:
- aircrack "KEY FOUND! [ <key> ]" lines
- aircrack live "Current passphrase: <value>" progress lines
- hashcat cracked hash:password output
- generic password/passphrase/psk keyword-value pairs
- consolidate duplicate `import re` into a single import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
color.py / scanner.py — replace deprecated os.popen('stty size') with shutil.get_terminal_size(fallback=...) which is safe in non-TTY contexts (piped/redirected output) and does not raise ValueError on empty output.
scanner.py — replace os.system() with subprocess.run([cmd]) for the clear-screen call, eliminating the shell spawn and making the intent explicit.
dependency.py — replace shell=True subprocess.run() with shell=False plus shlex.split() on the install command string, removing the shell injection vector in the package installer.
logger.py — extend _sanitize_message() to mask WPA/WEP credentials that may appear in logged output:
import reinto a single import