Added new test cases for latest wrapper by MohitMaliFtechiz · Pull Request #30 · kiwix/java-libkiwix

MohitMaliFtechiz · 2023-03-22T09:35:29Z

Fixes #29

In this PR we are adding new test cases for latest wrapper.

Added test cases for If archive created with invalid Zim file then it will throw error.
Added test case for removing book from library by id.

kelson42 · 2023-03-22T09:46:06Z

@MohitMaliFtechiz This PR has to be based on #27, I don't understand how this can work otherwise.

MohitMaliFtechiz · 2023-03-22T11:51:42Z

@MohitMaliFtechiz This PR has to be based on #27, I don't understand how this can work otherwise.

@kelson42 , i have made this branch from #27 and after that added new test cases in it, Once #27 is merged i'll re base this PR on main branch.

MohitMaliFtechiz · 2023-03-23T13:10:36Z

currently test cases are failing of because Linux libzim tar file containing 0 bytes .so file, so i have open a ticket for it in libzim openzim/libzim#772 .

MohitMaliFtechiz · 2023-04-04T12:58:19Z

For now i have made this branch from #31 to avoid the build failure because of linux zim file.

MohitMaliFtechiz · 2023-04-04T13:48:23Z

@mgautierfr , I am getting some errors while adding new test cases, can you please help me out on these errors.

When i am getting book from library Book book = lib.getBookById(bookIds[0]); via this method . It is giving error in utils.h

/media/hp-pc03/D/java-libkiwix/lib/src/main/cpp/utils.h:71: void setPtr(JNIEnv*, jobject, std::shared_ptr<_Tp>&&, const char*) [with T = const kiwix::Book; JNIEnv = JNIEnv_; jobject = _jobject*]: Assertion `env->GetLongField(thisObj, fieldId) == 0' failed.

When i am making object of query to test searcher Query query = new Query("test"); it is giving error. I think it means , it is not persent in .so file but we are including query.cpp while building the .so file. Is something missing in linux.so file or we are doing something wrong here?.

java.lang.UnsatisfiedLinkError: 'long org.kiwix.libzim.Query.setNativeQuery(java.lang.String)'
	at org.kiwix.libzim.Query.setNativeQuery(Native Method)
	at org.kiwix.libzim.Query.<init>(Query.java:25)
	at test.testSearcher(test.java:216)

When i am using suggestionSearch.getEstimatedMatches() it is returning 0 results. But i have tried small.zim with kiwix-app and search for test, there it is showing result in search result list .

I have push all the latest test cases on this PR. Currently CI is not running, Can you please try to run these tests locally.

kelson42 · 2023-04-11T16:21:14Z

@mgautierfr any update?

mgautierfr · 2023-04-26T14:25:11Z

@MohitMaliFtechiz First problem (setPtr) is fixed.
But there is something wrong in the build system. I've spend a lot of time try to fix a crash in java interpreter and it was because the test was using a old version of the java .class definition (I think). I suppose that buildsystem doesn't detect correctly that .class have changed and don't update the one in the test directory.

I'm looking for the two others issues.

But on my side, I face a new test failure where the illustration data is not equal to expected (test.java:137). It is probably because the String constructor interpret the bytes (and probably stop at first \0).

codecov-commenter · 2023-05-17T13:11:10Z

Codecov Report

❗ No coverage uploaded for pull request base (main@66ebc4e). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage        ?   42.39%           
  Complexity      ?       18           
=======================================
  Files           ?       24           
  Lines           ?       92           
  Branches        ?        6           
=======================================
  Hits            ?       39           
  Misses          ?       51           
  Partials        ?        2

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…for better readability

…st as we are generating the .so file in app/CMakeList now test/CMakeList file is unused so we are removing it

…only for running test cases, removed unnecessary check for directory in run_test.sh

…am for testing. In this commit we are compiling, running java test cases for gradle task, So we are removing the run_test.sh as it is unused now

… (libkiwix, libzim) , Now we are renameing the folders names via renameFolders method

… using the gradle tasks to compile and run test cases

…nuxBinding for better naming

…e , added remove book from library by id tests

…or getting books from library

Introduce a new set of wrapper (with a nice `2` postfix) with use a constructor taking a handle as parameter. It allow Book to have two constructor: - One creating a default empty (cpp) book. - One setting the wrapper around a exsiting cpp book.

Blob IS a `char[]`. C++ allow a char[] to be stored in a string but in java, a String is associated to a encoding. Content in a Blob may have no encoding so we cannot convert to a string. Fix the test part.

Correctly include `org_kiwix_libwzim_Query.h`. Property set the return type of setNativeQuery to void.

`Book::getIllustration(size)` return a `shared_ptr<Illustration>`. The current `buildWrapper` was creating a wrapper on a `shared_ptr<Illustration>` (so a `shared_ptr<shared_ptr<Illustration>>`) but we was converting to a `shared_ptr<Illustration>` and so we were doing wrong reads. By specializing the buildWrapper for `shared_ptr<T>`, we avoid the "double shared_ptr" and we are good.

`small.zim` doesn't seems to contain a xapian database, so searcher cannot work.

mgautierfr · 2023-05-20T15:16:25Z

The branch now compile and tests are passing.
Let's merge it and move on with a new iteration.

MohitMaliFtechiz marked this pull request as draft March 22, 2023 09:44

kelson42 mentioned this pull request Mar 22, 2023

Fixes of Broken CI #27

Merged

MohitMaliFtechiz force-pushed the Issue#29 branch from 085f748 to 531e46b Compare March 22, 2023 11:48

MohitMaliFtechiz closed this Mar 22, 2023

MohitMaliFtechiz reopened this Mar 22, 2023

MohitMaliFtechiz force-pushed the Issue#29 branch from 531e46b to 657da3b Compare March 23, 2023 08:54

MohitMaliFtechiz force-pushed the Issue#29 branch from 657da3b to 7473909 Compare April 4, 2023 12:54

mgautierfr marked this pull request as ready for review May 20, 2023 15:01

MohitMaliFtechiz and others added 14 commits May 20, 2023 17:05

Renamed generateHeaderFilesFromJavaWrapper method to generateHeaders …

78c57aa

…for better readability

Generating .aar file for android and .so file for testing via CmakeLi…

f2dfa01

…st as we are generating the .so file in app/CMakeList now test/CMakeList file is unused so we are removing it

Removed different tasks for coping libzim,libkiwix headers and .so files

cee67f6

Renamed compile_and_run_test.sh to run_test.sh as now this script is …

bc93a5d

…only for running test cases, removed unnecessary check for directory in run_test.sh

run_test.sh script now mostly run java compilation and run java progr…

5ec2f41

…am for testing. In this commit we are compiling, running java test cases for gradle task, So we are removing the run_test.sh as it is unused now

Removed dependency from date for copying the .so and headers files of…

fb380e2

… (libkiwix, libzim) , Now we are renameing the folders names via renameFolders method

Removed javac bash commands to compile and run test cases, now we are…

84235ee

… using the gradle tasks to compile and run test cases

Renamed generateHeader as buildHeader and buildLinuxSoFile as buildLi…

3fd6a01

…nuxBinding for better naming

Fixed source file path in compileTestFile task

bea92d8

Added test cases for checking is archive created with invalid zim fil…

d6e4479

…e , added remove book from library by id tests

Added test cases for searcher, SuggestionSearcher. Added test cases f…

c38ccd8

…or getting books from library

Added more test cases for bookmark

a0fd512

Correctly construct Book.

81993af

Introduce a new set of wrapper (with a nice `2` postfix) with use a constructor taking a handle as parameter. It allow Book to have two constructor: - One creating a default empty (cpp) book. - One setting the wrapper around a exsiting cpp book.

Make Blob.getData return a byte[] instead of a String.

915866a

Blob IS a `char[]`. C++ allow a char[] to be stored in a string but in java, a String is associated to a encoding. Content in a Blob may have no encoding so we cannot convert to a string. Fix the test part.

mgautierfr added 5 commits May 20, 2023 17:07

Fix Query.

4d73e57

Correctly include `org_kiwix_libwzim_Query.h`. Property set the return type of setNativeQuery to void.

Illustration.height must return the height.

9dee22f

Deactivate testSearcher() to fix.

3577824

`small.zim` doesn't seems to contain a xapian database, so searcher cannot work.

Switch ci to ubuntu 20.04

932faed

mgautierfr force-pushed the Issue#29 branch from 8233065 to 932faed Compare May 20, 2023 15:08

mgautierfr merged commit 8cc3627 into main May 20, 2023

mgautierfr deleted the Issue#29 branch May 20, 2023 15:16

mgautierfr mentioned this pull request Jun 14, 2023

Reorganise the gradle build script #32

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added new test cases for latest wrapper#30

Added new test cases for latest wrapper#30
mgautierfr merged 19 commits intomainfrom
Issue#29

MohitMaliFtechiz commented Mar 22, 2023

Uh oh!

kelson42 commented Mar 22, 2023

Uh oh!

MohitMaliFtechiz commented Mar 22, 2023

Uh oh!

MohitMaliFtechiz commented Mar 23, 2023 •

edited

Loading

Uh oh!

MohitMaliFtechiz commented Apr 4, 2023

Uh oh!

MohitMaliFtechiz commented Apr 4, 2023

Uh oh!

kelson42 commented Apr 11, 2023

Uh oh!

mgautierfr commented Apr 26, 2023

Uh oh!

codecov-commenter commented May 17, 2023

Uh oh!

mgautierfr commented May 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

MohitMaliFtechiz commented Mar 22, 2023

Uh oh!

kelson42 commented Mar 22, 2023

Uh oh!

MohitMaliFtechiz commented Mar 22, 2023

Uh oh!

MohitMaliFtechiz commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MohitMaliFtechiz commented Apr 4, 2023

Uh oh!

MohitMaliFtechiz commented Apr 4, 2023

Uh oh!

kelson42 commented Apr 11, 2023

Uh oh!

mgautierfr commented Apr 26, 2023

Uh oh!

codecov-commenter commented May 17, 2023

Codecov Report

Uh oh!

mgautierfr commented May 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MohitMaliFtechiz commented Mar 23, 2023 •

edited

Loading