test: Implement tests for Navigation history dialog#4811
Merged
kelson42 merged 4 commits intokiwix:mainfrom Apr 18, 2026
Merged
test: Implement tests for Navigation history dialog#4811kelson42 merged 4 commits intokiwix:mainfrom
kelson42 merged 4 commits intokiwix:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4811 +/- ##
============================================
+ Coverage 60.49% 60.51% +0.01%
+ Complexity 1675 1671 -4
============================================
Files 333 333
Lines 16020 16020
Branches 2225 2225
============================================
+ Hits 9692 9694 +2
- Misses 4855 4863 +8
+ Partials 1473 1463 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@MohitMaliFtechiz Please Take A look |
MohitMaliFtechiz
requested changes
Apr 13, 2026
harshsomankar123-tech
force-pushed
the
dialog
branch
from
dd2f343 to
1fbf95e
Compare
MohitMaliFtechiz
requested changes
Apr 15, 2026
Collaborator
MohitMaliFtechiz
left a comment
MohitMaliFtechiz
left a comment
There was a problem hiding this comment.
@harshsomankar123-tech There is a small change needed. After that, we are good to merge.
MohitMaliFtechiz
approved these changes
Apr 15, 2026
Collaborator
MohitMaliFtechiz
left a comment
MohitMaliFtechiz
left a comment
There was a problem hiding this comment.
@harshsomankar123-tech Thank you 🎉. Once CI is green, we will merge this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX #4809