Fix: Handle missing PipelineVersion in Kubernetes API mode#13222
Fix: Handle missing PipelineVersion in Kubernetes API mode#13222Goku2099 wants to merge 2 commits intokubeflow:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Goku2099. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix an issue where the Kubeflow Pipelines backend fails when accessing pipelines in Kubernetes API (CRD) mode when a PipelineVersion is not found. The fix modifies GetPipelineV1 to gracefully handle missing PipelineVersion by checking if the error message contains "not found", then setting pipelineVersion to nil and continuing instead of returning an error.
Changes:
- Modified
GetPipelineV1to catch "not found" errors fromgetLatestPipelineVersionand allow nil pipelineVersion instead of failing - Continues to return an error for other error cases
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
c71a8cd to
bdbd5ed
Compare
Fixes an issue where GetPipelineV1 fails if a PipelineVersion is not found.
The current implementation assumes that a "latest" PipelineVersion always exists and returns an error if it is missing ("PipelineVersion: Latest not found"). This causes the Kubeflow UI to fail when accessing pipelines created in Kubernetes API mode.
This PR updates the behavior to:
This ensures compatibility between v1beta1 API expectations and v2beta1 CRD-based pipelines.
Fixes #13216