Skip to content

fix(sagemaker): correct 'occured' -> 'occurred' in ERROR_UPDATE_MESSAGE#13279

Open
SAY-5 wants to merge 1 commit intokubeflow:masterfrom
SAY-5:fix-sagemaker-error-update-message-typo
Open

fix(sagemaker): correct 'occured' -> 'occurred' in ERROR_UPDATE_MESSAGE#13279
SAY-5 wants to merge 1 commit intokubeflow:masterfrom
SAY-5:fix-sagemaker-error-update-message-typo

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented Apr 15, 2026

components/aws/sagemaker/commonv2/sagemaker_component.py:287 defined ERROR_UPDATE_MESSAGE with the wrong spelling:

ERROR_NOT_CREATED_MESSAGE = "An error occurred while getting resource arn, ACK CR created but Sagemaker resource not created."
ERROR_UPDATE_MESSAGE = "An error occured when getting the resource arn. Check the ACK Sagemaker Controller logs."

The sibling constant on the line above (ERROR_NOT_CREATED_MESSAGE) already uses the correct occurred; align them. Both messages are surfaced when the SageMaker ACK controller fails to provision a CR, so the spelling reaches end users in pipeline error output. ast.parse clean against current master.

Copilot AI review requested due to automatic review settings April 15, 2026 16:34
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jsitu777 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link
Copy Markdown

Hi @SAY-5. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an end-user-facing typo in the SageMaker ACK controller error message surfaced during resource update failures, aligning it with the sibling “occurred” spelling used in the adjacent constant.

Changes:

  • Correct spelling in ERROR_UPDATE_MESSAGE from “occured” to “occurred”.

Copy link
Copy Markdown
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to sign your commit and get the CI passing - adding a -s while commiting will solve this

components/aws/sagemaker/commonv2/sagemaker_component.py defined
ERROR_UPDATE_MESSAGE with 'An error occured when getting the resource
arn. Check the ACK Sagemaker Controller logs.' The sibling constant
ERROR_NOT_CREATED_MESSAGE on the line above already uses the correct
spelling; align them. Both messages are surfaced when the SageMaker
ACK controller fails to provision a CR, so the spelling reaches end
users in pipeline error output.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@SAY-5 SAY-5 force-pushed the fix-sagemaker-error-update-message-typo branch from 857f78c to 287b105 Compare April 16, 2026 21:18
@SAY-5
Copy link
Copy Markdown
Author

SAY-5 commented Apr 16, 2026

@manaswinidas force-pushed with DCO Signed-off-by trailer. Should pass now.

@manaswinidas
Copy link
Copy Markdown
Contributor

/ok-to-test

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed All CI tests on a pull request have passed ok-to-test size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants