fix(sagemaker): correct 'occured' -> 'occurred' in ERROR_UPDATE_MESSAGE#13279
fix(sagemaker): correct 'occured' -> 'occurred' in ERROR_UPDATE_MESSAGE#13279SAY-5 wants to merge 1 commit intokubeflow:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @SAY-5. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
Fixes an end-user-facing typo in the SageMaker ACK controller error message surfaced during resource update failures, aligning it with the sibling “occurred” spelling used in the adjacent constant.
Changes:
- Correct spelling in
ERROR_UPDATE_MESSAGEfrom “occured” to “occurred”.
manaswinidas
left a comment
There was a problem hiding this comment.
You need to sign your commit and get the CI passing - adding a -s while commiting will solve this
components/aws/sagemaker/commonv2/sagemaker_component.py defined ERROR_UPDATE_MESSAGE with 'An error occured when getting the resource arn. Check the ACK Sagemaker Controller logs.' The sibling constant ERROR_NOT_CREATED_MESSAGE on the line above already uses the correct spelling; align them. Both messages are surfaced when the SageMaker ACK controller fails to provision a CR, so the spelling reaches end users in pipeline error output. Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
857f78c to
287b105
Compare
|
@manaswinidas force-pushed with DCO |
|
/ok-to-test |
components/aws/sagemaker/commonv2/sagemaker_component.py:287definedERROR_UPDATE_MESSAGEwith the wrong spelling:The sibling constant on the line above (
ERROR_NOT_CREATED_MESSAGE) already uses the correctoccurred; align them. Both messages are surfaced when the SageMaker ACK controller fails to provision a CR, so the spelling reaches end users in pipeline error output.ast.parseclean against currentmaster.