Skip to content

Add validation rules for streaming#531

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
serathius:validate-streaming
Mar 18, 2025
Merged

Add validation rules for streaming#531
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
serathius:validate-streaming

Conversation

@serathius
Copy link
Copy Markdown
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from roycaihw and seans3 March 18, 2025 18:19
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2025
@serathius serathius force-pushed the validate-streaming branch from 1c841c5 to 2134378 Compare March 18, 2025 18:21
@serathius
Copy link
Copy Markdown
Contributor Author

/assign @jpbetz

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Mar 18, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@serathius
Copy link
Copy Markdown
Contributor Author

@jpbetz is OOO
/assign @sttts

Co-authored-by: Jordan Liggitt <liggitt@google.com>
@serathius serathius force-pushed the validate-streaming branch from 2134378 to 0d9316e Compare March 18, 2025 18:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@serathius
Copy link
Copy Markdown
Contributor Author

Added tests

@serathius
Copy link
Copy Markdown
Contributor Author

/assign @Jefftree

@Jefftree
Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, liggitt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit c8a335a into kubernetes:master Mar 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants