Skip to content

chore: make IsSuccLimit a structure#38234

Open
vihdzp wants to merge 4 commits intoleanprover-community:masterfrom
vihdzp:succtop
Open

chore: make IsSuccLimit a structure#38234
vihdzp wants to merge 4 commits intoleanprover-community:masterfrom
vihdzp:succtop

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Apr 19, 2026

This lets us name the fields. Note that the mk_iff lemma overwrites a recently deprecated theorem.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

PR summary caf1dee8e5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsPredLimit
- IsSuccLimit.isSuccPrelimit
- IsSuccLimit.not_isMin
- isPredLimit_iff
- isSuccLimit_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-order Order theory label Apr 19, 2026
@[mk_iff]
structure IsSuccLimit (a : α) : Prop where
/-- Successor limits aren't minimal. -/
not_isMin : ¬ IsMin a
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
not_isMin : ¬ IsMin a
protected not_isMin : ¬ IsMin a

/-- Successor limits aren't minimal. -/
not_isMin : ¬ IsMin a
/-- Successor limits don't cover any other elements. -/
isSuccPrelimit : IsSuccPrelimit a
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isSuccPrelimit : IsSuccPrelimit a
protected isSuccPrelimit : IsSuccPrelimit a

@[mk_iff, to_dual existing]
structure IsPredLimit (a : α) : Prop where
/-- Predecessor limits aren't maximal. -/
not_isMax : ¬ IsMax a
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
not_isMax : ¬ IsMax a
protected not_isMax : ¬ IsMax a

/-- Predecessor limits aren't maximal. -/
not_isMax : ¬ IsMax a
/-- Predecessor limits aren't covered by any other elements. -/
isPredPrelimit : IsPredPrelimit a
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isPredPrelimit : IsPredPrelimit a
protected isPredPrelimit : IsPredPrelimit a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants