chore: make IsSuccLimit a structure#38234
Open
vihdzp wants to merge 4 commits intoleanprover-community:masterfrom
Open
chore: make IsSuccLimit a structure#38234vihdzp wants to merge 4 commits intoleanprover-community:masterfrom
IsSuccLimit a structure#38234vihdzp wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
PR summary caf1dee8e5Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
plp127
reviewed
Apr 20, 2026
| @[mk_iff] | ||
| structure IsSuccLimit (a : α) : Prop where | ||
| /-- Successor limits aren't minimal. -/ | ||
| not_isMin : ¬ IsMin a |
Contributor
There was a problem hiding this comment.
Suggested change
| not_isMin : ¬ IsMin a | |
| protected not_isMin : ¬ IsMin a |
| /-- Successor limits aren't minimal. -/ | ||
| not_isMin : ¬ IsMin a | ||
| /-- Successor limits don't cover any other elements. -/ | ||
| isSuccPrelimit : IsSuccPrelimit a |
Contributor
There was a problem hiding this comment.
Suggested change
| isSuccPrelimit : IsSuccPrelimit a | |
| protected isSuccPrelimit : IsSuccPrelimit a |
| @[mk_iff, to_dual existing] | ||
| structure IsPredLimit (a : α) : Prop where | ||
| /-- Predecessor limits aren't maximal. -/ | ||
| not_isMax : ¬ IsMax a |
Contributor
There was a problem hiding this comment.
Suggested change
| not_isMax : ¬ IsMax a | |
| protected not_isMax : ¬ IsMax a |
| /-- Predecessor limits aren't maximal. -/ | ||
| not_isMax : ¬ IsMax a | ||
| /-- Predecessor limits aren't covered by any other elements. -/ | ||
| isPredPrelimit : IsPredPrelimit a |
Contributor
There was a problem hiding this comment.
Suggested change
| isPredPrelimit : IsPredPrelimit a | |
| protected isPredPrelimit : IsPredPrelimit a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us name the fields. Note that the
mk_ifflemma overwrites a recently deprecated theorem.