Skip to content

refactor: not_isSuccLimit_iffnot_isSuccLimit_iff_succ_eq#38235

Open
vihdzp wants to merge 5 commits intoleanprover-community:masterfrom
vihdzp:succstuff
Open

refactor: not_isSuccLimit_iffnot_isSuccLimit_iff_succ_eq#38235
vihdzp wants to merge 5 commits intoleanprover-community:masterfrom
vihdzp:succstuff

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Apr 19, 2026

A lemma with such a simple name as not_isSuccLimit_iff shouldn't require a partial successor order! The new not_isSuccLimit_iff is a straightforward unfolding of the definitions and requires only a preorder.


Open in Gitpod

@vihdzp vihdzp added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-order Order theory labels Apr 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

PR summary 9ee33d6428

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ not_isPredPrelimit_iff_exists_covBy
+ not_isSuccPrelimit_iff_mem_range_succ
+ not_isSuccPrelimit_iff_succ_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vihdzp vihdzp changed the title refactor: not_isSuccLimit_iff → `not_isSuccLimit_iff_of_succOrder refactor: not_isSuccLimit_iffnot_isSuccLimit_iff_of_succOrder Apr 19, 2026
@vihdzp vihdzp changed the title refactor: not_isSuccLimit_iffnot_isSuccLimit_iff_of_succOrder refactor: not_isSuccLimit_iffnot_isSuccLimit_iff_succ_eq Apr 19, 2026
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant