Skip to content

feat: interactions between IsSuccLimit and WithTop#38244

Open
vihdzp wants to merge 10 commits intoleanprover-community:masterfrom
vihdzp:succtop2
Open

feat: interactions between IsSuccLimit and WithTop#38244
vihdzp wants to merge 10 commits intoleanprover-community:masterfrom
vihdzp:succtop2

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Apr 19, 2026

@github-actions github-actions Bot added the t-order Order theory label Apr 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

PR summary ee3a5404e5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsPredLimit.withTopCoe
+ IsSuccLimit.withTopCoe
+ IsSuccPrelimit.withTopCoe
+ _root_.WithTop.isPredPrelimit_iff
+ _root_.WithTop.isSuccLimit_iff
+ _root_.WithTop.isSuccLimit_top
+ _root_.WithTop.isSuccPrelimit_iff
+ _root_.WithTop.isSuccPrelimit_top
+ covBy_top_iff
+ not_covBy_top
+ not_top_covBy

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 19, 2026
Comment thread Mathlib/Order/SuccPred/Limit.lean Outdated
Comment thread Mathlib/Order/SuccPred/Limit.lean Outdated
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 20, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

vihdzp and others added 2 commits April 20, 2026 00:39
Co-authored-by: Snir Broshi <26556598+SnirBroshi@users.noreply.github.com>
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 20, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 21, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants