Skip to content

feat(LocalField): valuation of nonachimedean local field is rank one discrete#38251

Open
WenrongZou wants to merge 2 commits intoleanprover-community:masterfrom
WenrongZou:LF_rank
Open

feat(LocalField): valuation of nonachimedean local field is rank one discrete#38251
WenrongZou wants to merge 2 commits intoleanprover-community:masterfrom
WenrongZou:LF_rank

Conversation

@WenrongZou
Copy link
Copy Markdown
Contributor

@WenrongZou WenrongZou commented Apr 19, 2026

This PR add an instance that the valuation of nonarchimedean local field is rank one discrete.


Open in Gitpod

@github-actions github-actions Bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Apr 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

PR summary 700fcd702f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : IsCyclic (ValueGroupWithZero K)ˣ
+ instance : Nontrivial (ValueGroupWithZero K)ˣ

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Apr 19, 2026
@WenrongZou
Copy link
Copy Markdown
Contributor Author

I have a stupid question: if a instance is followed by inferInstance, do we actually need this instance in mathlib?

@github-actions github-actions Bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Apr 20, 2026
@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 20, 2026

Benchmark results for 8f4c22f against 700fcd7 are in. No significant results found. @MichaelStollBayreuth

  • 🟥 build//instructions: +17.2G (+0.01%)

Small changes (1✅, 2🟥)

  • build/module/Mathlib.Order.Synonym//instructions: -131.2M (-3.74%)
  • 🟥 build/module/Mathlib.Tactic.Change//instructions: +137.8M (+4.63%)
  • 🟥 build/module/Mathlib.Tactic.MinImports//instructions: +129.7M (+2.58%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants