Skip to content

[Merged by Bors] - chore(GroupTheory): deduplicate RootableBy.surjective_pow#38252

Closed
wwylele wants to merge 2 commits intoleanprover-community:masterfrom
wwylele:divisible-dedup
Closed

[Merged by Bors] - chore(GroupTheory): deduplicate RootableBy.surjective_pow#38252
wwylele wants to merge 2 commits intoleanprover-community:masterfrom
wwylele:divisible-dedup

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Apr 19, 2026

pow_left_surj_of_rootableBy and RootableBy.surjective_pow have the same statement, so this PR deprecates one of them. I kept the one with better naming (surj is not a widely used abbrev)


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

PR summary 700fcd702f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ smul_right_surj_of_divisibleBy

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-group-theory Group theory label Apr 19, 2026
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Apr 19, 2026

easy

@github-actions github-actions Bot added the easy < 20s of review time. See the lifecycle page for guidelines. label Apr 19, 2026
Comment thread Mathlib/GroupTheory/Divisible.lean Outdated
Co-authored-by: Artie Khovanov <artiekh@proton.me>
Copy link
Copy Markdown
Contributor

@tb65536 tb65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by tb65536.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 20, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request Apr 20, 2026
[pow_left_surj_of_rootableBy](https://leanprover-community.github.io/mathlib4_docs/Mathlib/GroupTheory/Divisible.html#pow_left_surj_of_rootableBy) and [RootableBy.surjective_pow](https://leanprover-community.github.io/mathlib4_docs/Mathlib/GroupTheory/Divisible.html#RootableBy.surjective_pow) have the same statement, so this PR deprecates one of them. I kept the one with better naming (`surj` is not a widely used abbrev)
@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 20, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 20, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(GroupTheory): deduplicate RootableBy.surjective_pow [Merged by Bors] - chore(GroupTheory): deduplicate RootableBy.surjective_pow Apr 20, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 20, 2026
@wwylele wwylele deleted the divisible-dedup branch April 20, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-group-theory Group theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants