[Merged by Bors] - chore(GroupTheory): deduplicate RootableBy.surjective_pow#38252
Closed
wwylele wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(GroupTheory): deduplicate RootableBy.surjective_pow#38252wwylele wants to merge 2 commits intoleanprover-community:masterfrom
wwylele wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 700fcd702fImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Collaborator
Author
|
easy |
artie2000
approved these changes
Apr 19, 2026
Co-authored-by: Artie Khovanov <artiekh@proton.me>
tb65536
approved these changes
Apr 20, 2026
Contributor
tb65536
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by tb65536. |
Member
|
Thanks! bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
[pow_left_surj_of_rootableBy](https://leanprover-community.github.io/mathlib4_docs/Mathlib/GroupTheory/Divisible.html#pow_left_surj_of_rootableBy) and [RootableBy.surjective_pow](https://leanprover-community.github.io/mathlib4_docs/Mathlib/GroupTheory/Divisible.html#RootableBy.surjective_pow) have the same statement, so this PR deprecates one of them. I kept the one with better naming (`surj` is not a widely used abbrev)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pow_left_surj_of_rootableBy and RootableBy.surjective_pow have the same statement, so this PR deprecates one of them. I kept the one with better naming (
surjis not a widely used abbrev)