Commit 6135887
Extend the reflection canary with a TIME column
The canary test in test_reflect_column_types covered every standard
SQLAlchemy type except Time. TIME columns round-trip through the
storage path (covered in test_time_and_reflection), but the metadata
path — what inspect(engine).get_columns() reports — had no guardrail
against a future pysqlite change demoting the column to NullType.
Add a Time column to the fixture and a bounded isinstance assertion
that tolerates pysqlite's version-dependent TIME mapping (Time,
String, or DateTime). The existing no-NullType sweep at the end of
the test remains the primary contract; the union assertion just
documents the concrete shape we observe today.
Does not add a _DqliteTime colspec — reflection via the pysqlite
parent is the deliberate current design.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 2d28ceb commit 6135887
1 file changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
| 52 | + | |
51 | 53 | | |
52 | 54 | | |
53 | 55 | | |
| |||
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
72 | 79 | | |
73 | 80 | | |
74 | 81 | | |
| |||
0 commit comments