Replace xmldom with jsdom#68
Merged
azhong-git merged 2 commits intomainfrom Apr 7, 2026
Merged
Conversation
azhong-git
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace xmldom which has critical vulnerability.
xmldom * Severity: critical xmldom allows multiple root nodes in a DOM - https://github.com/advisories/GHSA-crh6-fp67-6883 Misinterpretation of malicious XML input - https://github.com/advisories/GHSA-5fg8-2547-mr8q xmldom: XML injection via unsafe CDATA serialization allows attacker-controlled markup insertion - https://github.com/advisories/GHSA-wh4c-j3r5-mjhpThe jsdom 24.x pin is because jsdom 25+ pulls in ESM-only transitive dependencies (@csstools/*, parse5 v8) that break Jest's CommonJS module resolution. When the project eventually moves to an ESM-native test runner or Jest adds better ESM support, you can upgrade to jsdom 27.x.