Open
Conversation
Contributor
|
@cmungall is this still needed / ready to merge? |
- Wire CompressionEnum to the compression slot via `range: CompressionEnum` - Fix indentation on `targzip` permissible value (5 → 6 spaces) - Clean up trailing whitespace
There was a problem hiding this comment.
Pull request overview
This PR updates the LinkML datasets schema to better align dataset/resource serialization metadata with RML Target vocabulary and to introduce a controlled vocabulary for file compression types.
Changes:
- Fixes the
datasets:prefix URI to point athttps://w3id.org/linkml/datasets/. - Adds RML-related prefixes and maps
formattormlt:serialization. - Introduces
CompressionEnumand constrains thecompressionslot to that enum withrmlt:compression.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Update JSON meaning from rfc:rfc7159 (obsolete) to rfc:rfc8259 - Remove trailing blank line to pass yamllint and end-of-file-fixer
amc-corey-cox
approved these changes
Apr 16, 2026
Contributor
amc-corey-cox
left a comment
amc-corey-cox
left a comment
There was a problem hiding this comment.
@matentzn I don't think this is all that important but it is generally worth having. I fixed it up and it's ready to merge. I'll defer to you on when you'd like this to land. I patched up a couple minor things it needed to go in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.