fix: guard against empty data in plot_cnv_hmm_coverage_track#1307
Open
suhr25 wants to merge 2 commits intomalariagen:masterfrom
Open
fix: guard against empty data in plot_cnv_hmm_coverage_track#1307suhr25 wants to merge 2 commits intomalariagen:masterfrom
suhr25 wants to merge 2 commits intomalariagen:masterfrom
Conversation
Signed-off-by: Suhrid Marwah <suhridmarwah07@gmail.com>
Contributor
Author
|
Hi @jonbrenas, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a crash in
plot_cnv_hmm_coverage_trackwhen filtering leaves no data. Instead of throwing an error, the function now safely returnsNone.The change is small and limited to
malariagen_data/anoph/cnv_data.py.FIX
Before:
After:
VERIFICATION
Run the function on a region where all HMM calls are filtered out. Previously, this caused a crash. Now, it returns
Nonecleanly.Normal cases still behave exactly the same.