Add more tests

Author: marcbachmann

Gruntfile.coffee

@@ -1,23 +1,23 @@
 module.exports = (grunt) ->
 
   grunt.initConfig
-    mochaTest:
+    mochacli:
       test:
         options:
           ui: 'bdd'
           reporter: 'spec'
-          require: ['coffee-script']
+          compilers: ['coffee:coffee-script/register']
           slow: '1ms'
-
-        src: ['test/**/*.coffee']
+          timeout: '10s'
+          files: 'test/**/*'
 
     watch:
       tests:
         files: ['test/**/*.coffee', 'lib/**/*.coffee']
-        tasks: ['mochaTest']
+        tasks: ['mochacli']
 
 
-  grunt.loadNpmTasks('grunt-mocha-test')
+  grunt.loadNpmTasks('grunt-mocha-cli')
   grunt.loadNpmTasks('grunt-contrib-watch')
 
-  grunt.registerTask('test', ['mochaTest', 'watch'])
+  grunt.registerTask('test', ['mochacli', 'watch'])

lib/index.coffee

@@ -15,7 +15,7 @@ phantomjs = require('phantomjs')
 # - Page Footer  -> document.getElementById('pageFooter')
 #
 # When no #pageContent is available, phantomjs will use document.body as pdf content
-script = path.join(__dirname, 'scripts/pdf_a4_portrait.coffee')
+script = path.join(__dirname, 'scripts', 'pdf_a4_portrait.coffee')
 
 exports.create = (string, options, callback) ->
   if arguments.length == 2
@@ -45,7 +45,7 @@ exports.create = (string, options, callback) ->
     # Clean up the timeout cause the process ended anyways
     clearTimeout(timeout)
     if (stderr.length || code) > 0
-      error = new Error(Buffer.concat(stderr).toString() || 'Unknown Error')
+      error = new Error(Buffer.concat(stderr).toString() || 'html-pdf: Unknown Error')
       return callback(error)
 
     file = Buffer.concat(stdout)

lib/index.js

@@ -8,7 +8,7 @@ path = require('path');
 
 phantomjs = require('phantomjs');
 
-script = path.join(__dirname, 'scripts/pdf_a4_portrait.coffee');
+script = path.join(__dirname, 'scripts', 'pdf_a4_portrait.coffee');
 
 exports.create = function(string, options, callback) {
   var child, content, stderr, stdout, timeout;
@@ -41,7 +41,7 @@ exports.create = function(string, options, callback) {
     var error, file, filename, isFileBuffer;
     clearTimeout(timeout);
     if ((stderr.length || code) > 0) {
-      error = new Error(Buffer.concat(stderr).toString() || 'Unknown Error');
+      error = new Error(Buffer.concat(stderr).toString() || 'html-pdf: Unknown Error');
       return callback(error);
     }
     file = Buffer.concat(stdout);

package.json

@@ -12,15 +12,16 @@
   "author": "Marc Bachmann",
   "license": "MIT",
   "devDependencies": {
-    "coffee-script": "^1.7.1",
     "chai": "^1.9.1",
-    "grunt-mocha-test": "^0.10.2",
-    "grunt": "^0.4.4",
-    "mocha": "^1.18.2",
-    "grunt-contrib-watch": "^0.6.1"
+    "coffee-script": "^1.7.1",
+    "grunt": "^0.4.5",
+    "grunt-cli": "^0.1.13",
+    "grunt-contrib-watch": "^0.6.1",
+    "grunt-mocha-cli": "^1.11.0",
+    "mocha": "^1.18.2"
   },
   "dependencies": {
-    "phantomjs": "^1.9.7-8"
+    "phantomjs": "^1.9.8"
   },
   "repository": {
     "type": "git",

test/create.coffee

@@ -17,7 +17,7 @@ describe 'html-pdf', ->
             <div id="pageContent">Content</div>
             <div id="pageFooter">Footer</div>
           </body>
-        </html> 
+        </html>
       """
 
     it 'throws error when passing null', (done) ->
@@ -40,17 +40,29 @@ describe 'html-pdf', ->
 
     it 'does not throw an error when succeeding', (done) ->
       pdf.create @html, (error, pdf) =>
-        @pdf = pdf
         expect(error).to.be.null
-        fs.writeFile(path.join(__dirname,'simple.pdf'), pdf)
         done()
 
-    it 'returns a buffer', ->
-      expect(Buffer.isBuffer(@pdf), 'Should be a buffer').to.be.equal(true)
 
+    it 'buffer must be returned when no filename specified', (done) ->
+      pdf.create @html, (error, pdf) =>
+        expect(pdf).to.be.defined
+        done()
+
+
+    it 'returns a pdf buffer', (done) ->
+      pdf.create @html, (error, pdf) =>
+        expect(Buffer.isBuffer(pdf), 'Expect to be a pdf Buffer').to.be.equal(true)
+        expect(/^\%PDF-1.4/.test(pdf.toString()), 'Has a PDF header').to.be.equal(true)
+        done()
+
+
+    it 'saves the pdf to a destination', (done) ->
+      file = path.join(__dirname,'simple.pdf')
+      pdf.create @html, filename: file, (error, pdf) =>
+        expect(fs.existsSync(path.join(__dirname,'simple.pdf'))).to.equal(true)
+        done()
 
-    it 'returns a pdf buffer', ->
-      expect(/^\%PDF-1.4/.test(@pdf.toString()), 'Has a PDF header').to.be.equal(true)
 
     it 'works with a custom page size and footer', (done) ->
       options =
@@ -71,8 +83,9 @@ describe 'html-pdf', ->
       options =
         width: '50mm'
         height: '90mm'
+        filename: path.join(__dirname,'businesscard.pdf')
 
       pdf.create html, options,(error, pdf) =>
-        fs.writeFile(path.join(__dirname,'businesscard.pdf'), pdf)
         expect(error).to.be.null
+        expect(fs.existsSync(options.filename)).to.equal(true)
         done()