Implement WiFi auto-reconnect functionality#2482
Implement WiFi auto-reconnect functionality#2482Rococo88 wants to merge 1 commit intomeshcore-dev:mainfrom
Conversation
Added auto-reconnect feature for WiFi and event handler for disconnection.
liamcottle
left a comment
liamcottle
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR.
I've left a few review comments.
Please also change the PR branch to dev. You may need to rebase your fork to prevent the PR pulling in other commits if you change it from main.
| #ifdef WIFI_SSID | ||
| board.setInhibitSleep(true); // prevent sleep when WiFi is active | ||
| // Enable ESP-IDF auto-reconnect | ||
| WiFi.setAutoReconnect(true); |
There was a problem hiding this comment.
This shouldn't be needed since auto reconnect defaults to true in the underlying library, however we might as well be explicit about it. So it can stay.
| // Attach an event handler to force a reconnect specifically on disconnect events | ||
| WiFi.onEvent([](WiFiEvent_t event, WiFiEventInfo_t info){ | ||
| #ifdef WIFI_DEBUG_LOGGING | ||
| Serial.println("WiFi disconnected. Forcing reconnect..."); |
There was a problem hiding this comment.
Please remove the #ifdef sections and replace Serial.println(...) with WIFI_DEBUG_PRINTLN(...). The latter automatically handles the case where wifi debug logging is disabled.
|
Hey Liam, thanks for the review! I've updated the print statements to use WIFI_DEBUG_PRINTLN. I actually couldn't change the base branch to dev in the UI (the option wasn't there for me), so I'm closing this and opening a fresh PR targeting dev right now! |
2 participants
Added auto-reconnect feature for WiFi and event handler for disconnection. Tested on Xiao-S3 board, it reconnects properly after router reboot.