Skip to content

fix: address PR review comments on workflow files #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Harmanpreet-Microsoft wants to merge 1 commit into from
+3 −3
Closed

fix: address PR review comments on workflow files #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/azd-template-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TEMP: /tmp
fabricCapacityMode: 'none'
AZURE_PRINCIPAL_ID: ${{ vars.PRINCIPAL_ID || secrets.AZURE_CLIENT_ID }}
AZURE_PRINCIPAL_ID: ${{ vars.PRINCIPAL_ID || secrets.AZURE_PRINCIPAL_ID }}
AZURE_PRINCIPAL_TYPE: 'ServicePrincipal'
- name: print result
run: cat ${{ steps.validation.outputs.resultFile }}
4 changes: 2 additions & 2 deletions .github/workflows/azure-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ jobs:
echo "Resource group already exists: $RESOURCE_GROUP"
fi

# Set for subsequent steps
echo "RESOURCE_GROUP=$RESOURCE_GROUP" >> $GITHUB_ENV
# Export as AZURE_RESOURCE_GROUP so azd provision picks up the correct RG
echo "AZURE_RESOURCE_GROUP=$RESOURCE_GROUP" >> $GITHUB_ENV

- name: Provision Infrastructure
id: provision-main
Expand Down
Loading