Skip to content

fix: "Clear All" Button Not Resetting Search Box Text #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roopan-Microsoft merged 1 commit into from
Apr 9, 2025
Merged

fix: "Clear All" Button Not Resetting Search Box Text #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions App/frontend-app/src/pages/home/home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export function Home({ isSearchResultsPage }: HomeProps) {
const navigate = useNavigate();
const location = useLocation();
const [reset, setReset] = useState(false); // State to trigger reset

const [clearSearchBox, setClearSearchBox] = useState(false);
const [clearAllTriggered, setClearAllTriggered] = useState(false);
const [clearFilters, setClearFilters] = useState(false);
const [resetSearchBox, setResetSearchBox] = useState(false);
Expand Down Expand Up @@ -141,15 +141,16 @@ export function Home({ isSearchResultsPage }: HomeProps) {

useEffect(() => {
if (searchBoxRef.current) {
if (resetSearchBox) {

if (resetSearchBox && clearSearchBox) {
searchBoxRef.current.reset();
setResetSearchBox(false); // Reset the trigger
} else {
const urlQuery = searchParams.get("q");
if (urlQuery) {
const decodedQuery = decodeURIComponent(urlQuery);
searchBoxRef.current.setValue(decodedQuery);
if(!clearSearchBox){
const urlQuery = searchParams.get("q");
if (urlQuery) {
const decodedQuery = decodeURIComponent(urlQuery);
searchBoxRef.current.setValue(decodedQuery);
}
}
}
}
Expand All @@ -165,15 +166,24 @@ export function Home({ isSearchResultsPage }: HomeProps) {
setSearchParams({}); // Clear all search params when there's no query
}
} else {
const q = searchParams.get("q");
if (q) {
setQuery(decodeURIComponent(q));
if(!clearSearchBox){
const q = searchParams.get("q");
if (q) {
setQuery(decodeURIComponent(q));
}
}
}
}, [isSearchResultsPage, query, searchParams, setSearchParams]);

useEffect(() => {
const q = searchParams.get("q");
if(!q){
setClearSearchBox(false)
}
},[searchParams])

function onSearchChanged(searchValue: string): void {
if (searchValue) {
if (searchValue) {
setTextValue(searchValue);
}
if (searchValue) {
Expand All @@ -189,7 +199,7 @@ export function Home({ isSearchResultsPage }: HomeProps) {
}
} else {
setSearchResultDocuments([]);
setSearchParams("");
setSearchParams({});
setQuery(searchValue);
}
}
Expand Down Expand Up @@ -462,6 +472,7 @@ export function Home({ isSearchResultsPage }: HomeProps) {
setSelectedDocuments([]);
setClearAllTriggered(true); // Set this flag to true
setClearFilters(true);
setClearSearchBox(true);
// Call loadDataAsync after clearing
loadDataAsync();
}, [/* dependencies */]);
Expand Down