Skip to content

refactor: centralize Azure resource naming with abbreviations.json and update Bicep templates#381

Merged
Roopan-Microsoft merged 1 commit intodevfrom
dev-biceprefactoring
May 14, 2025
Merged

refactor: centralize Azure resource naming with abbreviations.json and update Bicep templates#381
Roopan-Microsoft merged 1 commit intodevfrom
dev-biceprefactoring

Conversation

@Harmanpreet-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request updates the Deployment/main.bicep file to standardize resource naming by introducing an abbreviations.json file for consistent naming conventions across resources. The changes improve maintainability and ensure uniformity in resource names.

Resource Naming Standardization:

  • Introduced a var abbrs variable to load abbreviations from abbreviations.json for resource naming. ([Deployment/main.bicepR5-R53](https://github.com/microsoft/Document-Knowledge-Mining-Solution-Accelerator/pull/381/files#diff-56f936106def10cad9c186b743f6d514131224ac7156924173d909aa816740b8R5-R53))
  • Updated resource group, storage account, Azure Search Service, container registry, AKS cluster, Azure Cognitive Service, Azure OpenAI Service, and Azure Cosmos DB naming to use the abbreviations from abbrs. ([[1]](https://github.com/microsoft/Document-Knowledge-Mining-Solution-Accelerator/pull/381/files#diff-56f936106def10cad9c186b743f6d514131224ac7156924173d909aa816740b8R5-R53), [[2]](https://github.com/microsoft/Document-Knowledge-Mining-Solution-Accelerator/pull/381/files#diff-56f936106def10cad9c186b743f6d514131224ac7156924173d909aa816740b8L77-R91), [[3]](https://github.com/microsoft/Document-Knowledge-Mining-Solution-Accelerator/pull/381/files#diff-56f936106def10cad9c186b743f6d514131224ac7156924173d909aa816740b8L141-R145))
  • Modified the output gs_resourcegroup_name to use the new naming convention based on abbrs. ([Deployment/main.bicepL160-R161](https://github.com/microsoft/Document-Knowledge-Mining-Solution-Accelerator/pull/381/files#diff-56f936106def10cad9c186b743f6d514131224ac7156924173d909aa816740b8L160-R161))
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 74deb6e into dev May 14, 2025
5 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the dev-biceprefactoring branch May 14, 2025 11:25
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants