refactor: centralize Azure resource naming with abbreviations.json and update Bicep templates#381
Merged
Roopan-Microsoft merged 1 commit intodevfrom May 14, 2025
Merged
Conversation
Roopan-Microsoft
approved these changes
May 14, 2025
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the
Deployment/main.bicepfile to standardize resource naming by introducing anabbreviations.jsonfile for consistent naming conventions across resources. The changes improve maintainability and ensure uniformity in resource names.Resource Naming Standardization:
var abbrsvariable to load abbreviations fromabbreviations.jsonfor resource naming. ([Deployment/main.bicepR5-R53](https://github.com/microsoft/Document-Knowledge-Mining-Solution-Accelerator/pull/381/files#diff-56f936106def10cad9c186b743f6d514131224ac7156924173d909aa816740b8R5-R53))abbrs. ([[1]](https://github.com/microsoft/Document-Knowledge-Mining-Solution-Accelerator/pull/381/files#diff-56f936106def10cad9c186b743f6d514131224ac7156924173d909aa816740b8R5-R53),[[2]](https://github.com/microsoft/Document-Knowledge-Mining-Solution-Accelerator/pull/381/files#diff-56f936106def10cad9c186b743f6d514131224ac7156924173d909aa816740b8L77-R91),[[3]](https://github.com/microsoft/Document-Knowledge-Mining-Solution-Accelerator/pull/381/files#diff-56f936106def10cad9c186b743f6d514131224ac7156924173d909aa816740b8L141-R145))gs_resourcegroup_nameto use the new naming convention based onabbrs. ([Deployment/main.bicepL160-R161](https://github.com/microsoft/Document-Knowledge-Mining-Solution-Accelerator/pull/381/files#diff-56f936106def10cad9c186b743f6d514131224ac7156924173d909aa816740b8L160-R161))Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information