Skip to content

fix: merging dev to main#384

Merged
Roopan-Microsoft merged 4 commits intomainfrom
dev
May 21, 2025
Merged

fix: merging dev to main#384
Roopan-Microsoft merged 4 commits intomainfrom
dev

Conversation

@Roopan-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

  • This pull request introduces a new JSON file containing standardized abbreviations for resource naming (abbreviations.json) and updates the main.bicep file to use these abbreviations for consistent and concise resource naming. The key changes involve loading the abbreviations JSON, replacing hardcoded resource names with dynamic names based on the abbreviations, and ensuring uniformity across resource types.

Addition of Abbreviations File:

  • Deployment/abbreviations.json: Added a comprehensive JSON file that defines abbreviations for various Azure resource types, categorized by themes such as AI, analytics, compute, databases, and more. This file will serve as a centralized reference for resource naming conventions.

Updates to Resource Naming in main.bicep:

  • General Changes:

    • Deployment/main.bicep: Introduced a loadJsonContent function to load the abbreviations JSON file into a variable (abbrs) for use in dynamic resource naming.
  • Resource Name Updates:

    • Updated the naming of the resource group to use the managementGovernance.resourceGroup abbreviation.
    • Replaced hardcoded names for storage accounts, Azure Search services, and container registries with names derived from their respective abbreviations (storage.storageAccount, ai.aiSearch, containers.containerRegistry).
    • Updated the AKS cluster name to use the compute.arcEnabledKubernetesCluster abbreviation.
    • Modified the Azure Cognitive Service and OpenAI Service names to use ai.documentIntelligence and ai.openAIService abbreviations, respectively.
    • Updated the Cosmos DB name to use the databases.cosmosDBDatabase abbreviation.
  • Output Updates:

    • Updated the output for the resource group name to dynamically use the managementGovernance.resourceGroup abbreviation.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Harmanpreet Kaur and others added 4 commits May 13, 2025 17:35
refactor: centralize Azure resource naming with abbreviations.json and update Bicep templates
feat: add centralized abbreviations.json to standardize Azure resource naming
@Roopan-Microsoft Roopan-Microsoft merged commit c9d3be8 into main May 21, 2025
8 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants