Skip to content

fix: quota check script incorrect response #423

Merged
Roopan-Microsoft merged 1 commit intodevfrom
psl-bug-20642
Jul 17, 2025
Merged

fix: quota check script incorrect response #423
Roopan-Microsoft merged 1 commit intodevfrom
psl-bug-20642

Conversation

@Priyanka-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

  • ...
    This pull request updates the Deployment/quota_check_params.sh script to improve flexibility for handling model types and to adjust formatting for better output readability. The most important changes include modifying logic for model type selection, updating model-specific conditions, and adjusting table column widths in the output.

Changes to model type handling:

  • Removed the special case for text-embedding-ada-002 in model type selection, allowing all models to use the same logic for defining MODEL_TYPES.

  • Updated the model-specific condition to check for text-embedding-3-large instead of text-embedding-ada-002, aligning with the updated model naming convention.

Changes to output formatting:

  • Increased the width of the "Model Name" column in the output table from 43 to 45 characters to accommodate longer model names. This change was applied in both the table row formatting and the header. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 9e63c8b into dev Jul 17, 2025
5 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-bug-20642 branch July 17, 2025 13:58
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants