fix: quota check script incorrect response #423
Merged
Roopan-Microsoft merged 1 commit intodevfrom Jul 17, 2025
Merged
Conversation
Roopan-Microsoft
approved these changes
Jul 17, 2025
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the
Deployment/quota_check_params.shscript to improve flexibility for handling model types and to adjust formatting for better output readability. The most important changes include modifying logic for model type selection, updating model-specific conditions, and adjusting table column widths in the output.Changes to model type handling:
Removed the special case for
text-embedding-ada-002in model type selection, allowing all models to use the same logic for definingMODEL_TYPES.Updated the model-specific condition to check for
text-embedding-3-largeinstead oftext-embedding-ada-002, aligning with the updated model naming convention.Changes to output formatting:
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information