fix: replace DefaultAzureCredential with ManagedIdentityCredential#431
Merged
Prajwal-Microsoft merged 1 commit intomainfrom Jul 31, 2025
Merged
fix: replace DefaultAzureCredential with ManagedIdentityCredential#431Prajwal-Microsoft merged 1 commit intomainfrom
Prajwal-Microsoft merged 1 commit intomainfrom
Conversation
Prajwal-Microsoft
approved these changes
Jul 31, 2025
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces a new helper class to centralize Azure credential management and updates the configuration logic to use this helper. The changes improve maintainability and make the credential selection process more flexible based on the environment.
Azure Credential Management:
AzureCredentialHelperinApp/backend-api/Microsoft.GS.DPS.Host/Helpers/AzureCredentialHelper.csto encapsulate logic for obtaining Azure credentials. It supports both development and production environments, with an optional client ID for user-assigned managed identities.Configuration Updates:
Configmethod inAppConfiguration.csto useAzureCredentialHelper.GetAzureCredential()instead of directly instantiatingDefaultAzureCredential. This improves flexibility and aligns with the new helper class.Microsoft.GS.DPSHost.HelpersinAppConfiguration.csto enable the use of the new helper class.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information