fix: added new 'type' tag for WAF and Non-WAF deployement#467
Merged
Roopan-Microsoft merged 1 commit intodevfrom Sep 23, 2025
Merged
fix: added new 'type' tag for WAF and Non-WAF deployement#467Roopan-Microsoft merged 1 commit intodevfrom
Roopan-Microsoft merged 1 commit intodevfrom
Conversation
VishalS-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Roopan-Microsoft
approved these changes
Sep 23, 2025
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the tagging logic in the
resourceGroupTagsresource within the infrastructure Bicep template. The main change is to standardize theTemplateNametag and introduce a newTypetag to distinguish between WAF and Non-WAF deployments.Tagging improvements:
TemplateNametag to always use'DKM', removing conditional logic.Typetag that conditionally sets its value to'WAF'or'Non-WAF'based on theenablePrivateNetworkingparameter.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information