Skip to content

fix: Optimize the network module for DKM#482

Merged
Prajwal-Microsoft merged 6 commits intodevfrom
psl-network-dkm
Oct 29, 2025
Merged

fix: Optimize the network module for DKM#482
Prajwal-Microsoft merged 6 commits intodevfrom
psl-network-dkm

Conversation

@Prekshith-Microsoft
Copy link
Copy Markdown
Contributor

This pull request refactors the networking and private endpoint architecture in the main infrastructure Bicep template. The changes consolidate the network, Bastion Host, and Jumpbox VM provisioning into a new unified virtualNetwork module and update all dependent modules to reference outputs from this new module. This improves maintainability, clarity, and future extensibility of the deployment. The legacy network.bicep and bastionHost.bicep modules are removed, and all private endpoint subnet references are updated accordingly.

Networking architecture refactor:

  • Replaces the legacy network module with a new virtualNetwork module that provisions the Virtual Network, subnets (including for private endpoints, Bastion Host, and Jumpbox VM), NSGs, Bastion Host, and Jumpbox VM in a single place (infra/main.bicep, infra/modules/network.bicep, infra/modules/network/bastionHost.bicep). [1] [2] [3]

Private endpoint subnet references update:

  • Updates all modules that create private endpoints (CosmosDB, AppConfig, Storage Account, Search, OpenAI, Document Intelligence) to reference virtualNetwork!.outputs.pepsSubnetResourceId instead of the old network!.outputs.subnetPrivateEndpointsResourceId (infra/main.bicep). [1] [2] [3] [4] [5] [6] [7]

AKS subnet reference update:

  • Switches the AKS cluster subnet reference to use the dedicated AKS subnet output from the new virtualNetwork module (infra/main.bicep).

Private DNS zone and output improvements:

  • Updates the private DNS zone and output references to use the new virtualNetwork module outputs, and ensures outputs are safely handled if values are missing (infra/main.bicep). [1] [2]

Legacy module cleanup:

  • Removes the old network.bicep and bastionHost.bicep modules and their parameters, outputs, and type definitions (infra/modules/network.bicep, infra/modules/network/bastionHost.bicep). [1] [2]## Purpose
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Prajwal-Microsoft Prajwal-Microsoft merged commit ae28697 into dev Oct 29, 2025
5 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Priyanka-Microsoft Priyanka-Microsoft deleted the psl-network-dkm branch December 25, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants