fix: Optimize the network module for DKM#482
Merged
Prajwal-Microsoft merged 6 commits intodevfrom Oct 29, 2025
Merged
Conversation
Prajwal-Microsoft
approved these changes
Oct 29, 2025
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the networking and private endpoint architecture in the main infrastructure Bicep template. The changes consolidate the network, Bastion Host, and Jumpbox VM provisioning into a new unified
virtualNetworkmodule and update all dependent modules to reference outputs from this new module. This improves maintainability, clarity, and future extensibility of the deployment. The legacynetwork.bicepandbastionHost.bicepmodules are removed, and all private endpoint subnet references are updated accordingly.Networking architecture refactor:
networkmodule with a newvirtualNetworkmodule that provisions the Virtual Network, subnets (including for private endpoints, Bastion Host, and Jumpbox VM), NSGs, Bastion Host, and Jumpbox VM in a single place (infra/main.bicep,infra/modules/network.bicep,infra/modules/network/bastionHost.bicep). [1] [2] [3]Private endpoint subnet references update:
virtualNetwork!.outputs.pepsSubnetResourceIdinstead of the oldnetwork!.outputs.subnetPrivateEndpointsResourceId(infra/main.bicep). [1] [2] [3] [4] [5] [6] [7]AKS subnet reference update:
virtualNetworkmodule (infra/main.bicep).Private DNS zone and output improvements:
virtualNetworkmodule outputs, and ensures outputs are safely handled if values are missing (infra/main.bicep). [1] [2]Legacy module cleanup:
network.bicepandbastionHost.bicepmodules and their parameters, outputs, and type definitions (infra/modules/network.bicep,infra/modules/network/bastionHost.bicep). [1] [2]## PurposeDoes this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information