fix: Merging the changes from dev to main#484
Merged
Prajwal-Microsoft merged 4 commits intomainfrom Oct 28, 2025
Merged
Conversation
chore: updated script to assign AKS cluster role to user
fix: Prevent removal of existing RG tags when deploying GSA
Kanchan-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Prajwal-Microsoft
approved these changes
Oct 28, 2025
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to the Azure Kubernetes Service (AKS) deployment process and enhances resource group tag management. The most significant updates are the automation of AKS RBAC role assignment for the current user and the inheritance of existing resource group tags in infrastructure deployment.
Deployment automation and access control:
resourcedeployment.ps1) now checks if the current user already has the "Azure Kubernetes Service RBAC Cluster Admin" role on the AKS cluster. If not, it automatically assigns this role, ensuring the user has the necessary permissions to manage the cluster.Infrastructure and tagging improvements:
main.bicep) for resource group tags now merges any existing tags from the resource group with new deployment tags, ensuring that previously set tags are preserved and not overwritten during deployments.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information